Skip to content

Commit 25c673b

Browse files
manickiWMDE bot
authored andcommitted
Removed (Serializable)EntityId::isForeign
the concept of "entities from a foreign repositories" has not been integrated into Wikibase. Bug: T291823 Depends-On: I54e4e12f4cda2a3966c727c45a953ba17dc11a73 Change-Id: I6895bc5ebe50eadc2a584c8c72547f79f1053fac
1 parent d362254 commit 25c673b

2 files changed

Lines changed: 0 additions & 15 deletions

File tree

src/Entity/SerializableEntityId.php

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -149,15 +149,6 @@ public function getLocalPart() {
149149
return $this->localPart;
150150
}
151151

152-
/**
153-
* Returns true iff SerializableEntityId::getRepositoryName returns a non-empty string.
154-
*
155-
* @return bool
156-
*/
157-
public function isForeign() {
158-
return $this->repositoryName !== '';
159-
}
160-
161152
/**
162153
* @param string $id
163154
*

tests/unit/Entity/EntityIdTest.php

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -101,12 +101,6 @@ public function testReturnTypeOfToString( EntityId $id ) {
101101
$this->assertIsString( $id->__toString() );
102102
}
103103

104-
public function testIsForeign() {
105-
$this->assertFalse( ( new ItemId( 'Q42' ) )->isForeign() );
106-
$this->assertFalse( ( new ItemId( ':Q42' ) )->isForeign() );
107-
$this->assertFalse( ( new NumericPropertyId( ':P42' ) )->isForeign() );
108-
}
109-
110104
/**
111105
* @dataProvider instanceProvider
112106
*/

0 commit comments

Comments
 (0)