Skip to content

Commit b8de754

Browse files
committed
Merge pull request #432 from wmde/deprecatedClaim2
Drop obsolete Claim related test code
2 parents 402590a + f28eced commit b8de754

3 files changed

Lines changed: 2 additions & 17 deletions

File tree

tests/unit/Entity/Diff/EntityDiffTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,8 +119,8 @@ public function testGetClaimsDiff( EntityDiff $entityDiff ) {
119119
foreach ( $diff as $diffOp ) {
120120
$this->assertTrue( $diffOp instanceof DiffOpAdd || $diffOp instanceof DiffOpRemove );
121121

122-
$claim = $diffOp instanceof DiffOpAdd ? $diffOp->getNewValue() : $diffOp->getOldValue();
123-
$this->assertInstanceOf( 'Wikibase\DataModel\Claim\Claim', $claim );
122+
$statement = $diffOp instanceof DiffOpAdd ? $diffOp->getNewValue() : $diffOp->getOldValue();
123+
$this->assertInstanceOf( 'Wikibase\DataModel\Statement\Statement', $statement );
124124
}
125125
}
126126

tests/unit/Statement/StatementListTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
namespace Wikibase\DataModel\Tests\Statement;
44

55
use DataValues\StringValue;
6-
use Wikibase\DataModel\Claim\Claim;
76
use Wikibase\DataModel\Claim\Claims;
87
use Wikibase\DataModel\Entity\PropertyId;
98
use Wikibase\DataModel\Snak\PropertyNoValueSnak;

tests/unit/Statement/StatementTest.php

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
namespace Wikibase\DataModel\Tests\Statement;
44

55
use DataValues\StringValue;
6-
use Wikibase\DataModel\Claim\Claim;
76
use Wikibase\DataModel\Entity\PropertyId;
87
use Wikibase\DataModel\Reference;
98
use Wikibase\DataModel\ReferenceList;
@@ -200,19 +199,6 @@ public function testSetInvalidRank( Statement $statement ) {
200199
$statement->setRank( 9001 );
201200
}
202201

203-
public function testStatementRankCompatibility() {
204-
$this->assertEquals( Claim::RANK_DEPRECATED, Statement::RANK_DEPRECATED );
205-
$this->assertEquals( Claim::RANK_PREFERRED, Statement::RANK_PREFERRED );
206-
$this->assertEquals( Claim::RANK_NORMAL, Statement::RANK_NORMAL );
207-
}
208-
209-
/**
210-
* @dataProvider instanceProvider
211-
*/
212-
public function testIsClaim( Statement $statement ) {
213-
$this->assertInstanceOf( 'Wikibase\DataModel\Claim\Claim', $statement );
214-
}
215-
216202
/**
217203
* @dataProvider instanceProvider
218204
*/

0 commit comments

Comments
 (0)