Merge pull request #429 from wmde/hasClaims

Drop deprecated Entity::hasClaims

Author: JeroenDeDauw

RELEASE-NOTES.md

@@ -11,6 +11,7 @@
 	* `Statement::setClaim` and `Statement::getClaim` have been removed
 	* Removed `ClaimList`
 	* Removed `ClaimListAccess`
+	* Removed `hasClaims` from all entity classes
 * Removed `Claims::getBestClaims` (you can use `StatementList::getBestStatements` instead)
 * Removed `Claims::getByRank` and `Claims::getByRanks` (you can use `StatementList::getWithRank` instead)
 * Removed `Claims::getMainSnaks` (you can use `StatementList::getMainSnaks` instead)

src/Entity/Entity.php

@@ -371,21 +371,6 @@ public function getClaims() {
 		return array();
 	}
 
-	/**
-	 * Convenience function to check if the entity contains any claims.
-	 *
-	 * On top of being a convenience function, this implementation allows for doing
-	 * the check without forcing an unstub in contrast to count( $this->getClaims() ).
-	 *
-	 * @since 0.2
-	 * @deprecated since 1.0, use getStatements()->isEmpty() instead.
-	 *
-	 * @return bool
-	 */
-	public function hasClaims() {
-		return false;
-	}
-
 	/**
 	 * @since 0.3
 	 * @deprecated since 1.0, use new Statement() instead.

src/Entity/Item.php

@@ -290,15 +290,6 @@ public function setClaims( Claims $claims ) {
 		$this->statements = new StatementList( iterator_to_array( $claims ) );
 	}
 
-	/**
-	 * @deprecated since 1.0, use getStatements()->isEmpty() instead.
-	 *
-	 * @return bool
-	 */
-	public function hasClaims() {
-		return !$this->statements->isEmpty();
-	}
-
 	/**
 	 * @see Comparable::equals
 	 *

src/Entity/Property.php

@@ -223,15 +223,6 @@ public function setClaims( Claims $claims ) {
 		$this->statements = new StatementList( iterator_to_array( $claims ) );
 	}
 
-	/**
-	 * @deprecated since 1.0, use getStatements()->isEmpty() instead.
-	 *
-	 * @return bool
-	 */
-	public function hasClaims() {
-		return !$this->statements->isEmpty();
-	}
-
 	/**
 	 * @deprecated since 1.0, use new Statement() instead.
 	 *

tests/unit/Entity/EntityTest.php

@@ -403,17 +403,6 @@ public function testSerialize( Entity $entity ) {
 		$this->assertEquals( $entity->getId(), $instance->getId() );
 	}
 
-	/**
-	 * @dataProvider instanceProvider
-	 * @param Entity $entity
-	 */
-	public function testHasClaims( Entity $entity ) {
-		$has = $entity->hasClaims();
-		$this->assertInternalType( 'boolean', $has );
-
-		$this->assertEquals( count( $entity->getClaims() ) !== 0, $has );
-	}
-
 	public function diffProvider() {
 		$argLists = array();