We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
2 parents e4f7778 + 685e94b commit 6e322eaCopy full SHA for 6e322ea
1 file changed
src/HashArray.php
@@ -205,8 +205,6 @@ public function removeByElementHash( $elementHash ) {
205
* @return boolean Indicates if the element was added or not.
206
*/
207
public function addElement( Hashable $element ) {
208
- // TODO: this duplicates logic of preSetElement
209
- // Probably best update setElement in GenericArrayObject to return boolean it got from preSetElement
210
$append = $this->acceptDuplicates || !$this->hasElementHash( $element->getHash() );
211
212
if ( $append ) {
0 commit comments