Skip to content

Commit 685e94b

Browse files
committed
Remove TODO
This is not needed and would cause a command query sepearation violation
1 parent 454243e commit 685e94b

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

src/HashArray.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -205,8 +205,6 @@ public function removeByElementHash( $elementHash ) {
205205
* @return boolean Indicates if the element was added or not.
206206
*/
207207
public function addElement( Hashable $element ) {
208-
// TODO: this duplicates logic of preSetElement
209-
// Probably best update setElement in GenericArrayObject to return boolean it got from preSetElement
210208
$append = $this->acceptDuplicates || !$this->hasElementHash( $element->getHash() );
211209

212210
if ( $append ) {

0 commit comments

Comments
 (0)