Dropped "repository name" and "local part" from EntityId

Bug: T291823
Depends-On: I13e3c1a238459dd26ba2e613d78eb7b87bb35533
Depends-On: I7bb37487c706afe8244129472bd35cf536eca62a
Change-Id: Ie9661c0e89d03afc28845e374f24dbed22cdee74

Author: manicki

src/Entity/EntityId.php

@@ -32,22 +32,6 @@ public function __toString();
 	 */
 	public function equals( $target );
 
-	/**
-	 * TODO: This method shouldn't exist on this interface as it doesn't make sense for certain types of IDs. It should be moved to a
-	 *       separate interface, or removed altogether.
-	 *
-	 * @return string
-	 */
-	public function getLocalPart();
-
-	/**
-	 * TODO: This method shouldn't exist on this interface as it doesn't make sense for certain types of IDs. It should be moved to a
-	 *       separate interface, or removed altogether.
-	 *
-	 * @return string
-	 */
-	public function getRepositoryName();
-
 	/**
 	 * This method replaces {@link Serializable::serialize()}.
 	 * Do not call it manually.

src/Entity/ItemId.php

@@ -76,8 +76,6 @@ public function serialize() {
 
 	public function __unserialize( array $data ): void {
 		$this->serialization = $data['serialization'];
-		list( $this->repositoryName, $this->localPart ) =
-			self::extractRepositoryNameAndLocalPart( $this->serialization );
 	}
 
 	/**
@@ -89,8 +87,6 @@ public function unserialize( $serialized ) {
 		$array = json_decode( $serialized );
 		$this->serialization = is_array( $array ) ? $array[1] : $serialized;
 		$this->serialization = $this->serialization ?? '';
-		list( $this->repositoryName, $this->localPart ) =
-			self::extractRepositoryNameAndLocalPart( $this->serialization );
 	}
 
 	/**

src/Entity/NumericPropertyId.php

@@ -70,8 +70,6 @@ public function serialize() {
 
 	public function __unserialize( array $data ): void {
 		$this->serialization = $data['serialization'];
-		list( $this->repositoryName, $this->localPart ) =
-			self::extractRepositoryNameAndLocalPart( $this->serialization );
 	}
 
 	/**
@@ -83,8 +81,6 @@ public function unserialize( $serialized ) {
 		$array = json_decode( $serialized );
 		$this->serialization = is_array( $array ) ? $array[1] : $serialized;
 		$this->serialization = $this->serialization ?? '';
-		list( $this->repositoryName, $this->localPart ) =
-			self::extractRepositoryNameAndLocalPart( $this->serialization );
 	}
 
 	/**

src/Entity/SerializableEntityId.php

@@ -12,16 +12,6 @@ abstract class SerializableEntityId implements EntityId {
 
 	protected $serialization;
 
-	/**
-	 * @var string
-	 */
-	protected $repositoryName;
-
-	/**
-	 * @var string
-	 */
-	protected $localPart;
-
 	public const PATTERN = '/^[^:]+\z/';
 
 	/**
@@ -32,8 +22,6 @@ abstract class SerializableEntityId implements EntityId {
 	public function __construct( $serialization ) {
 		self::assertValidSerialization( $serialization );
 		$this->serialization = self::normalizeIdSerialization( $serialization );
-
-		list( $this->repositoryName, $this->localPart ) = self::extractRepositoryNameAndLocalPart( $serialization );
 	}
 
 	private static function assertValidSerialization( $serialization ) {
@@ -62,25 +50,6 @@ public function getSerialization() {
 		return $this->serialization;
 	}
 
-	/**
-	 * Returns '' for local IDs and the foreign repository name for foreign IDs. For chained IDs (e.g. foo:bar:Q42) it
-	 * will return only the first part.
-	 *
-	 * @return string
-	 */
-	public function getRepositoryName() {
-		return $this->repositoryName;
-	}
-
-	/**
-	 * Returns the serialization without the first repository prefix.
-	 *
-	 * @return string
-	 */
-	public function getLocalPart() {
-		return $this->localPart;
-	}
-
 	/**
 	 * @param string $id
 	 *
@@ -119,17 +88,4 @@ abstract public function __serialize(): array;
 
 	abstract public function __unserialize( array $serialized ): void;
 
-	/**
-	 * Returns a pair (repository name, local part of ID) from the given ID serialization.
-	 * Note: this does not perform any validation of the given input. Calling code should take
-	 * care of this!
-	 *
-	 * @param string $serialization
-	 *
-	 * @return string[] Array of form [ string $repositoryName, string $localPart ]
-	 */
-	protected static function extractRepositoryNameAndLocalPart( $serialization ) {
-		return array_pad( explode( ':', $serialization, 2 ), -2, '' );
-	}
-
 }

tests/fixtures/CustomEntityId.php

@@ -27,8 +27,6 @@ public function serialize() {
 
 	public function __unserialize( array $data ): void {
 		$this->serialization = $data['serialization'];
-		$this->repositoryName = '';
-		$this->localPart = $data['serialization'];
 	}
 
 	/**
@@ -38,8 +36,6 @@ public function __unserialize( array $data ): void {
 	 */
 	public function unserialize( $serialized ) {
 		$this->serialization = $serialized;
-		$this->repositoryName = '';
-		$this->localPart = $serialized;
 	}
 
 	/**

tests/unit/Entity/EntityIdTest.php

@@ -101,18 +101,6 @@ public function testReturnTypeOfToString( EntityId $id ) {
 		$this->assertIsString( $id->__toString() );
 	}
 
-	/**
-	 * @dataProvider instanceProvider
-	 */
-	public function testGetRepositoryName( EntityId $id, $repoName ) {
-		$this->assertSame( $repoName, $id->getRepositoryName() );
-	}
-
-	public function testGetLocalPart() {
-		$id = new ItemId( 'Q42' );
-		$this->assertSame( 'Q42', $id->getLocalPart() );
-	}
-
 	public static function invalidSerializationProvider() {
 		return [
 			[ 'foo:Q42' ],