Removed SerializableEntityId::splitSerialization

Bug: T291823
Depends-On: Ibea6e9236a80b1f132f27dd646ad7a0fa1fe7bf6
Change-Id: Ie3fdbde264ad9b27037915399482c21b7c9c6cce

Author: manicki

src/Entity/SerializableEntityId.php

@@ -62,53 +62,6 @@ public function getSerialization() {
 		return $this->serialization;
 	}
 
-	/**
-	 * Returns an array with 3 elements: the foreign repository name as the first element, the local ID as the last
-	 * element and everything that is in between as the second element.
-	 *
-	 * SerializableEntityId::joinSerialization can be used to restore the original serialization from the parts returned.
-	 *
-	 * @param string $serialization
-	 *
-	 * @throws InvalidArgumentException
-	 * @return string[] Array containing the serialization split into 3 parts.
-	 */
-	public static function splitSerialization( $serialization ) {
-		self::assertValidSerialization( $serialization );
-
-		return self::extractSerializationParts( self::normalizeIdSerialization( $serialization ) );
-	}
-
-	/**
-	 * Splits the given ID serialization into an array with the following three elements:
-	 *  - the repository name as the first element (empty string for local repository)
-	 *  - any parts of the ID serialization but the repository name and the local ID (if any, empty string
-	 *    if nothing else present)
-	 *  - the local ID
-	 * Note: this method does not perform any validation of the given input. Calling code should take
-	 * care of this!
-	 *
-	 * @param string $serialization
-	 *
-	 * @return string[]
-	 */
-	private static function extractSerializationParts( $serialization ) {
-		$parts = explode( ':', $serialization );
-		$localPart = array_pop( $parts );
-		$repoName = array_shift( $parts );
-		$prefixRemainder = implode( ':', $parts );
-
-		if ( $repoName !== null ) {
-			throw new InvalidArgumentException( 'repo name no longer supported (T291823)' );
-		}
-
-		return [
-			is_string( $repoName ) ? $repoName : '',
-			$prefixRemainder,
-			$localPart,
-		];
-	}
-
 	/**
 	 * Returns '' for local IDs and the foreign repository name for foreign IDs. For chained IDs (e.g. foo:bar:Q42) it
 	 * will return only the first part.

tests/unit/Entity/EntityIdTest.php

@@ -108,27 +108,6 @@ public function testGetRepositoryName( EntityId $id, $repoName ) {
 		$this->assertSame( $repoName, $id->getRepositoryName() );
 	}
 
-	public static function serializationSplitProvider() {
-		return [
-			[ 'Q42', [ '', '', 'Q42' ] ],
-		];
-	}
-
-	/**
-	 * @dataProvider serializationSplitProvider
-	 */
-	public function testSplitSerialization( $serialization, $split ) {
-		$this->assertSame( $split, SerializableEntityId::splitSerialization( $serialization ) );
-	}
-
-	/**
-	 * @dataProvider invalidSerializationProvider
-	 */
-	public function testSplitSerializationFails_GivenInvalidSerialization( $serialization ) {
-		$this->expectException( InvalidArgumentException::class );
-		SerializableEntityId::splitSerialization( $serialization );
-	}
-
 	public function testGetLocalPart() {
 		$id = new ItemId( 'Q42' );
 		$this->assertSame( 'Q42', $id->getLocalPart() );