Removed SerializableEntityId::joinSerialization

Bug: T291823
Depends-On: Ibea6e9236a80b1f132f27dd646ad7a0fa1fe7bf6
Change-Id: Ieab04771a60be89de0095cfaa121e85eb073c418

Author: manicki

src/Entity/SerializableEntityId.php

@@ -109,27 +109,6 @@ private static function extractSerializationParts( $serialization ) {
 		];
 	}
 
-	/**
-	 * Builds an ID serialization from the parts returned by SerializableEntityId::splitSerialization.
-	 *
-	 * @param string[] $parts
-	 *
-	 * @throws InvalidArgumentException
-	 * @return string
-	 */
-	public static function joinSerialization( array $parts ) {
-		if ( end( $parts ) === '' ) {
-			throw new InvalidArgumentException( 'The last element of $parts must not be empty.' );
-		}
-
-		return implode(
-			':',
-			array_filter( $parts, function( $part ) {
-				return $part !== '';
-			} )
-		);
-	}
-
 	/**
 	 * Returns '' for local IDs and the foreign repository name for foreign IDs. For chained IDs (e.g. foo:bar:Q42) it
 	 * will return only the first part.

tests/unit/Entity/EntityIdTest.php

@@ -129,29 +129,6 @@ public function testSplitSerializationFails_GivenInvalidSerialization( $serializ
 		SerializableEntityId::splitSerialization( $serialization );
 	}
 
-	/**
-	 * @dataProvider serializationSplitProvider
-	 */
-	public function testJoinSerialization( $serialization, $split ) {
-		$this->assertSame( $serialization, SerializableEntityId::joinSerialization( $split ) );
-	}
-
-	/**
-	 * @dataProvider invalidJoinSerializationDataProvider
-	 */
-	public function testJoinSerializationFails_GivenEmptyId( $parts ) {
-		$this->expectException( InvalidArgumentException::class );
-		SerializableEntityId::joinSerialization( $parts );
-	}
-
-	public static function invalidJoinSerializationDataProvider() {
-		return [
-			[ [ 'Q42', '', '' ] ],
-			[ [ '', 'Q42', '' ] ],
-			[ [ 'foo', 'Q42', '' ] ],
-		];
-	}
-
 	public function testGetLocalPart() {
 		$id = new ItemId( 'Q42' );
 		$this->assertSame( 'Q42', $id->getLocalPart() );