Removed Claims::equals

Author: JeroenDeDauw

RELEASE-NOTES.md

@@ -15,6 +15,7 @@
 * Removed `Claims::getClaimsForProperty` (you can use `StatementList::getWithPropertyId` instead)
 * Removed `Claims::getHashes`
 * Removed `Claims::getGuids`
+* Removed `Claims::equals` (and `Claims` no longer implements `Comparable`)
 
 ## Version 2.6.0 (2015-03-08)
 

src/Claim/Claims.php

@@ -22,7 +22,7 @@
  * @author Daniel Kinzler
  * @author H. Snater < mediawiki@snater.com >
  */
-class Claims extends ArrayObject implements Hashable, Comparable {
+class Claims extends ArrayObject implements Hashable {
 
 	/**
 	 * @see GenericArrayObject::__construct
@@ -306,38 +306,4 @@ public function isEmpty() {
 		return !$this->getIterator()->valid();
 	}
 
-	/**
-	 * @see Comparable::equals
-	 *
-	 * @since 0.7.4
-	 *
-	 * @param mixed $target
-	 *
-	 * @return bool
-	 */
-	public function equals( $target ) {
-		if ( $this === $target ) {
-			return true;
-		}
-
-		if ( !( $target instanceof self )
-			|| $this->count() !== $target->count()
-		) {
-			return false;
-		}
-
-		foreach ( $this as $claim ) {
-			if ( !$target->hasExactClaim( $claim ) ) {
-				return false;
-			}
-		}
-
-		return true;
-	}
-
-	private function hasExactClaim( Claim $claim ) {
-		return $this->hasClaim( $claim )
-			&& $this->getClaimWithGuid( $claim->getGuid() )->equals( $claim );
-	}
-
 }

tests/unit/Claim/ClaimsTest.php

@@ -462,53 +462,4 @@ public function testIsEmpty() {
 		$this->assertTrue( $claims->isEmpty() );
 	}
 
-	public function testEmptyListEqualsEmptyList() {
-		$list = new Claims( array() );
-		$this->assertTrue( $list->equals( clone $list ) );
-	}
-
-	public function testFilledListEqualsItself() {
-		$list = new Claims( array(
-			$this->makeStatement( new PropertyNoValueSnak( new PropertyId( 'P1' ) ) ),
-			$this->makeStatement( new PropertyNoValueSnak( new PropertyId( 'P2' ) ) ),
-		) );
-
-		$this->assertTrue( $list->equals( $list ) );
-		$this->assertTrue( $list->equals( clone $list ) );
-	}
-
-	public function testGivenNonClaimList_equalsReturnsFalse() {
-		$list = new Claims( array() );
-
-		$this->assertFalse( $list->equals( null ) );
-		$this->assertFalse( $list->equals( new \stdClass() ) );
-	}
-
-	public function testGivenDifferentList_equalsReturnsFalse() {
-		$list = new Claims( array(
-			$this->makeStatement( new PropertyNoValueSnak( new PropertyId( 'P1' ) ) ),
-			$this->makeStatement( new PropertyNoValueSnak( new PropertyId( 'P2' ) ) ),
-		) );
-
-		$otherList = new Claims( array(
-			$this->makeStatement( new PropertyNoValueSnak( new PropertyId( 'P3' ) ) ),
-			$this->makeStatement( new PropertyNoValueSnak( new PropertyId( 'P4' ) ) ),
-		) );
-
-		$this->assertFalse( $list->equals( $otherList ) );
-	}
-
-	public function testGivenDifferentClaimWithSameGuid_equalsReturnsFalse() {
-		$claim = new Claim( new PropertyNoValueSnak( 42 ) );
-		$claim->setGuid( 'kittens' );
-
-		$newClaim = new Claim( new PropertyNoValueSnak( 1337 ) );
-		$newClaim->setGuid( 'kittens' );
-
-		$list = new Claims( array( $claim ) );
-		$newList = new Claims( array( $newClaim ) );
-
-		$this->assertFalse( $list->equals( $newList ) );
-	}
-
 }