Removed Claims::getHashes and Claims::getGuids

Author: JeroenDeDauw

RELEASE-NOTES.md

@@ -13,6 +13,8 @@
 * Removed `Claims::getByRank` and `Claims::getByRanks` (you can use `StatementList::getWithRank` instead)
 * Removed `Claims::getMainSnaks` (you can use `StatementList::getMainSnaks` instead)
 * Removed `Claims::getClaimsForProperty` (you can use `StatementList::getWithPropertyId` instead)
+* Removed `Claims::getHashes`
+* Removed `Claims::getGuids`
 
 ## Version 2.6.0 (2015-03-08)
 

src/Claim/Claims.php

@@ -279,38 +279,6 @@ public function offsetUnset( $guid ) {
 		parent::offsetUnset( $key );
 	}
 
-	/**
-	 * Get array of Claim guids
-	 *
-	 * @since 0.4
-	 *
-	 * @return string[]
-	 */
-	public function getGuids() {
-		return array_map( function ( Claim $claim ) {
-			return $claim->getGuid();
-		}, iterator_to_array( $this ) );
-	}
-
-	/**
-	 * Returns a map from GUIDs to claim hashes.
-	 *
-	 * @since 0.4
-	 *
-	 * @return string[]
-	 */
-	public function getHashes() {
-		$snaks = array();
-
-		/* @var Claim $claim */
-		foreach ( $this as $claim ) {
-			$guid = $claim->getGuid();
-			$snaks[$guid] = $claim->getHash();
-		}
-
-		return $snaks;
-	}
-
 	/**
 	 * Returns a hash based on the value of the object.
 	 * The hash is based on the hashes of the claims contained,

tests/unit/Claim/ClaimsTest.php

@@ -384,48 +384,6 @@ public function testGuidNormalization() {
 		$this->assertEquals( $claim2, $claims->getClaimWithGuid( $claim2UpperGuid ) );
 	}
 
-	public function testGetGuids() {
-		$claims = new Claims( array(
-			$this->makeClaim( new PropertyNoValueSnak( new PropertyId( 'P42' ) ) ),
-			$this->makeClaim( new PropertySomeValueSnak( new PropertyId( 'P42' ) ) ),
-			$this->makeClaim( new PropertyNoValueSnak( new PropertyId( 'P23' ) ) ),
-			$this->makeClaim( new PropertyNoValueSnak( new PropertyId( 'P9000' ) ) ),
-		) );
-
-		$guids = $claims->getGuids();
-		$this->assertInternalType( 'array', $guids );
-		$this->assertSameSize( $claims, $guids );
-
-		foreach ( $guids as $guid ) {
-			$this->assertInternalType( 'string', $guid );
-			$this->assertTrue( $claims->hasClaimWithGuid( $guid ) );
-		}
-	}
-
-	public function testGetHashes() {
-		$claims = new Claims( array(
-			$this->makeClaim( new PropertyNoValueSnak( new PropertyId( 'P42' ) ) ),
-			$this->makeClaim( new PropertySomeValueSnak( new PropertyId( 'P42' ) ) ),
-			$this->makeClaim( new PropertyNoValueSnak( new PropertyId( 'P23' ) ) ),
-			$this->makeClaim( new PropertyNoValueSnak( new PropertyId( 'P9000' ) ) ),
-		) );
-
-		$hashes = $claims->getHashes();
-		$this->assertInternalType( 'array', $hashes );
-		$this->assertContainsOnly( 'string', $hashes );
-		$this->assertSameSize( $claims, $hashes );
-
-		$hashSet = array_flip( $hashes );
-
-		/**
-		 * @var Claim $claim
-		 */
-		foreach ( $claims as $claim ) {
-			$hash = $claim->getHash();
-			$this->assertArrayHasKey( $hash, $hashSet );
-		}
-	}
-
 	/**
 	 * Attempts to add Claims with no GUID set will fail.
 	 */