Skip to content

add missing search icon#5500

Merged
DedeHai merged 1 commit intowled:mainfrom
DedeHai:fix_UIfont
Apr 12, 2026
Merged

add missing search icon#5500
DedeHai merged 1 commit intowled:mainfrom
DedeHai:fix_UIfont

Conversation

@DedeHai
Copy link
Copy Markdown
Collaborator

@DedeHai DedeHai commented Apr 12, 2026

in the UI font project json file the "search" icon was missing. The update of "file" and "pixelforge" icon ported that error into the UI.
This PR adds the icon back.

Note: this also needs 16.0 backport or cherry pick.

Summary by CodeRabbit

  • New Features

    • Added a search icon to the available icon library.
  • Improvements

    • Optimized icon font delivery and display rendering for better performance.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 12, 2026

Walkthrough

Added a new search icon (glyph code e0a1) to the WLED icon set with corresponding catalog metadata, demo documentation, CSS styles, and cache-busting updates to icon font assets across multiple configuration files.

Changes

Cohort / File(s) Summary
Icon Catalog & Font Configuration
wled00/data/icons-ui/selection.json, wled00/data/icons-ui/style.css, wled00/data/index.css
Added new search icon entry with metadata (id: 134, code: 57505/e0a1, grid: 16). Updated existing icon entries' setIdx, setId, and iconIdx values. Modified @font-face cache-busting query strings (?yzxblb?2tjc6). Updated embedded WOFF2 base64 payload in WIcons font. Refreshed preferences tokens.
Icon Demo UI
wled00/data/icons-ui/demo.html, wled00/data/icons-ui/demo-files/demo.css
Incremented glyph count display from 25 to 26. Added i-search icon demo block with codepoint display (e0a1/). Reduced .fs1 font-size from 48px to 32px.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Suggested reviewers

  • softhack007
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'add missing search icon' directly and concisely describes the main change: adding a search icon that was omitted from the UI font project JSON.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@wled00/data/icons-ui/demo-files/demo.css`:
- Line 150: The CSS line containing the declaration "font-size: 32px;" uses
space indentation; replace the leading spaces with a single tab character to
comply with the project's tab-indentation rule for CSS (ensure the line begins
with a tab before font-size: 32px; and no leading spaces remain).

In `@wled00/data/icons-ui/demo.html`:
- Around line 16-29: The inserted HTML glyph block (the <div class="glyph fs1">
... </div> containing <span class="i-search">, the fieldset and input elements)
is indented with spaces; update the indentation to use tabs throughout this
block to comply with the project's HTML style for files under wled00/data
(convert all leading space characters at the start of each line inside the <div
class="glyph fs1"> block to tab characters so nested elements like <div
class="clearfix bshadow0 pbs">, <fieldset class="fs0 size1of1 clearfix
hidden-false">, and their <input> and <span> children align with tab-based
indentation).

In `@wled00/data/icons-ui/selection.json`:
- Line 1: The new "search" icon entry has mismatched codepoints: defaultCode is
59782 while properties.code is 57505 (0xE0A1); update the "search" icon's
defaultCode to 57505 so defaultCode and properties.code match (ensure the icon
object with "name":"search" and id:134 has defaultCode set to 57505).

In `@wled00/data/icons-ui/style.css`:
- Around line 4-6: The updated CSS blocks using font URLs (the block containing
"url('fonts/wled122.ttf?2tjc6') format('truetype'),
url('fonts/wled122.woff?2tjc6') format('woff'),
url('fonts/wled122.svg?2tjc6#wled122') format('svg');" and the similar block at
lines 27-29) are indented with spaces—convert those leading spaces to tab
characters so the font-face/url lines follow the project's tab-indentation
convention for CSS (replace the leading spaces on each affected line with a
single tab).

In `@wled00/data/index.css`:
- Line 3: The modified `@font-face` `src:` line currently uses space indentation;
update the indentation to a single tab character to match the web UI guideline
for files matching wled00/data/**/*.{html,js,css}. Locate the `src:` line inside
the `@font-face` block (the line beginning with "src: url(data:font/woff2...") and
replace its leading spaces with a tab so the line starts with a tab followed by
"src:".
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 822a4158-38ca-41f6-a5b5-b4093ebf17b5

📥 Commits

Reviewing files that changed from the base of the PR and between 36ebcb5 and f3386ca.

⛔ Files ignored due to path filters (4)
  • wled00/data/icons-ui/fonts/wled122.svg is excluded by !**/*.svg
  • wled00/data/icons-ui/fonts/wled122.ttf is excluded by !**/*.ttf
  • wled00/data/icons-ui/fonts/wled122.woff is excluded by !**/*.woff
  • wled00/data/icons-ui/fonts/wled122.woff2 is excluded by !**/*.woff2
📒 Files selected for processing (5)
  • wled00/data/icons-ui/demo-files/demo.css
  • wled00/data/icons-ui/demo.html
  • wled00/data/icons-ui/selection.json
  • wled00/data/icons-ui/style.css
  • wled00/data/index.css

@netmindz netmindz added this to the 16.0.0 beta milestone Apr 12, 2026
@DedeHai DedeHai merged commit 1185886 into wled:main Apr 12, 2026
25 checks passed
DedeHai added a commit that referenced this pull request Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants