Skip to content

Address dependency vulnerability. #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
barnson wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Address dependency vulnerability. #718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed34e82
Don't fail long-path test on ReFS/DevDrive volumes
barnson Aug 10, 2026
543a46a
Address dependency vulnerability.
barnson Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/internal/SetBuildNumber/Directory.Packages.props.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,6 @@
<PackageVersion Include="Microsoft.AspNetCore.Owin" Version="8.0.21" />
<PackageVersion Include="Microsoft.VisualStudio.Setup.Configuration.Native" Version="3.14.2075" />
<PackageVersion Include="Microsoft.Win32.Registry" Version="5.0.0" />

<!-- Pin System.Private.Uri address security vulnerabilities in transitive dependencies. Review as dependencies update. -->
<PackageVersion Include="System.Private.Uri" Version="4.3.2" />

<!-- Use System.Memory v4.5.5 as it is compatible with VS2022 -->
<PackageVersion Include="System.Memory" Version="4.5.5" />
</ItemGroup>

<!-- NuGet stack -->
Expand All @@ -87,7 +81,7 @@

<!-- Keep the following versions in sync with internal\WixInternal.TestSupport.Native\packages.config -->
<ItemGroup>
<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="8.0.0" />
<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="10.0.401" />

<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
<PackageVersion Include="xunit" Version="2.9.3" />
Expand Down
16 changes: 15 additions & 1 deletion src/wix/test/WixToolsetTest.CoreIntegration/LongPathFixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ public void TestLongPathSupport()
}

var intermediateFolder = Path.Combine(baseFolder, "obj");
var outputPath = Path.Combine(baseFolder, "bin", "test.msi");

var result = WixRunner.Execute(
[
Expand All @@ -45,9 +46,22 @@ public void TestLongPathSupport()
"-loc", Path.Combine(folder, "Package.en-us.wxl"),
"-bindpath", Path.Combine(folder, "data"),
"-intermediateFolder", intermediateFolder,
"-o", Path.Combine(baseFolder, "bin", "test.msi")
"-o", outputPath,
]);

if (result.ExitCode == 223/*WindowsInstallerBackendErrors.OpenDatabaseFailed*/
&& result.Messages.Length > 0)
{
// In a bit of a twist, WiX's long-path support relies on 8.3 short file names. As
// [Raymond Chen suggests](https://devblogs.microsoft.com/oldnewthing/20181004-00/?p=99895),
// not all file systems support 8.3 names. That includes ReFS, the file system used
// by Dev Drives. So pass the test if the failure is due to missing 8.3 names.
Assert.Equal(outputPath, result.Messages[0].MessageArgs[0]);
Assert.Equal("The Windows Installer service failed to start. Contact your support personnel.", result.Messages[0].MessageArgs[1]);

return;
}

result.AssertSuccess();

Assert.True(File.Exists(Path.Combine(baseFolder, "bin", "test.msi")));
Expand Down
Loading