Add defensive checks before calling isFocused#44
Open
bausmeier wants to merge 1 commit intowix-incubator:masterfrom
Open
Add defensive checks before calling isFocused#44bausmeier wants to merge 1 commit intowix-incubator:masterfrom
bausmeier wants to merge 1 commit intowix-incubator:masterfrom
Conversation
When making use of useRef for refs forwarded to a custom functional component there is potential for the isFocused function not to be defined. Adding some extra checks to make sure that it is a function before calling it prevents an error from being thrown.
|
It would be great to get this one merged! We're running into scenarios where the ref may be null. |
|
yes, come across the same issue, pls help solve it asap, thanks alot TypeError: Cannot read property 'isFocused' of null |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When making use of useRef for refs forwarded to a custom functional
component there is potential for the isFocused function not to be
defined. Adding some extra checks to make sure that it is a function
before calling it prevents an error from being thrown.