Skip to content

WPB-11756 Check length when verifying user passwords #5543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
VeryMilkyJoe wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

WPB-11756 Check length when verifying user passwords #5543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions libs/types-common/src/Data/Misc.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ module Data.Misc
fromPlainTextPassword,
plainTextPassword8Unsafe,
plainTextPassword6Unsafe,
toPlainTextPassword8,

-- * Typesafe FUTUREWORKS
FutureWork (..),
Expand Down Expand Up @@ -531,6 +532,9 @@ plainTextPassword8Unsafe = PlainTextPassword' . unsafeRange
fromPlainTextPassword :: PlainTextPassword' t -> Text
fromPlainTextPassword = fromRange . fromPlainTextPassword'

toPlainTextPassword8 :: PlainTextPassword6 -> Maybe PlainTextPassword8
toPlainTextPassword8 = fmap PlainTextPassword' . checked . fromPlainTextPassword

newtype PlainTextPassword' (minLen :: Nat) = PlainTextPassword'
{fromPlainTextPassword' :: Range minLen (1024 :: Nat) Text}
deriving stock (Eq, Generic)
Expand Down
6 changes: 5 additions & 1 deletion libs/wire-subsystems/src/Wire/AuthenticationSubsystem/Interpreter.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ module Wire.AuthenticationSubsystem.Interpreter
)
where

import Control.Lens
import Data.ByteString.Conversion
import Data.Code qualified as Code
import Data.Default
Expand Down Expand Up @@ -400,7 +401,10 @@ verifyUserPasswordImpl uid plaintext = do
password <-
UserStore.lookupHashedPassword uid
>>= maybe (throw AuthenticationSubsystemBadCredentials) pure
verifyPasswordWithStatus (RateLimitUser uid) plaintext password
verifiedPassword <- verifyPasswordWithStatus (RateLimitUser uid) plaintext password
case toPlainTextPassword8 plaintext of
Just {} -> pure $ verifiedPassword & _2 .~ PasswordStatusNeedsUpdate
Nothing -> pure verifiedPassword

verifyUserPasswordErrorImpl ::
( Member (Error AuthenticationSubsystemError) r,
Expand Down