feat(observability): add db query duration histogram and pool exhaustion monitoring#2
Open
winniebyte wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements two monitoring features:
Issue solutions-plug#964 - Database Query Duration Histogram
db_query_duration_secondsPrometheus histogram with buckets [0.01, 0.05, 0.1, 0.25, 0.5, 1, 2.5, 5]db.rsviawith_timeout()to record query durationsDBSlowQueryP95firing when P95 exceeds 500ms for 5 minutesIssue solutions-plug#965 - Database Connection Pool Exhaustion Alert
db_pool_exhaustion_totalcounter inmetrics.rs, incremented on pool timeout errorsDBPoolExhaustionfiring when rate exceeds 1/minutealerts.yamlwith pool exhaustion alert ruleTesting
observe_db_query_durationandobserve_db_pool_exhaustionmetricsCloses solutions-plug#964
Closes solutions-plug#965