Fix connection leaks and UDP session races - #223
Merged
Merged
Conversation
tomaskir
added a commit
to tomaskir/vllm-wg-dockerized
that referenced
this pull request
Sep 24, 2026
…leak fixes No wireproxy release exists past v1.1.3 (2026-07-16), but master carries two fixes on the TCPServerTunnel path we rely on: - windtf/wireproxy#222: every closed tunnel connection logged "ERROR: Cannot forward traffic: ... use of closed network connection". It goes through wireproxy's own logger, so `-s` never silenced it. - windtf/wireproxy#223: when the loopback target refused (e.g. vLLM still loading), the WG-side connection was never closed and the peer hung until its own timeout. Reproduced both with two userspace peers over loopback running the entrypoint's config shape under -s. v1.1.3 logged 30 "use of closed network connection" lines for 10 aborted SSE streams, and requests to a port with no listener timed out. The a4c5269 build logged 0 such lines and the refused connections closed immediately (curl: empty reply). `wireproxy -n` and `-s` behave the same, and upstream `go test` passes. The fetch stage becomes a Go build stage. It stays pinned end to end: the golang image by digest, the source by full commit SHA (checked after checkout), and the modules by go.sum (`go mod verify`). CLAUDE.md now describes this pinning and says to return to the release tarball + SHA256 once a release containing both fixes ships.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix multiple memory leaks in the project
CheckAliveIntervaland non-negativeInactivityTimeout.