Repository navigation
Host checks: follow the sources merged since wave 6 - #564
Merged
125hz merged 2 commits intoNov 5, 2026
Merged
Conversation
Ten host checks fail on main (5fda6a0) because production code changed after they were written. The production code is right in each case, so the checks are updated and production is left alone: - check-background-run: 1dbd877 added a second line (the MADEIRA_AUDIO_RESUME suspended mark) to madeira_audio_background's start condition, and 0a2e6ed's render callback also bumps cb_epoch in its paused branch, before mixing. The check now anchors the two-line condition and takes the last cb_epoch. - check-d3d9-older-nvidia: willfaust#530 expected the label as compatLabel(L("Older NVIDIA card (Direct3D 9)"), but willfaust#528, merged just before it, rewrote that row without L(). Either form passes now. - check-epic-games, check-itch-store: the Other games filter gained $0.listedInLibrary (0a2e6ed) and $0.gogProductID (GOG store, willfaust#551), in the middle of the substrings the checks looked for. They now look for the Epic and itch.io conditions on their own. - check-hardware-input: since 0a2e6ed pSetCursorPos reports through winios_direct_cursor_warp when the app has it. The regex follows. - check-library-groups: the production Group by rules call L() (willfaust#530). The harness defines it as check-frontend.py and check-runtime-settings.py do. - check-pointer-capture: the production capture methods read Self.hiddenCursorAbsolute (willfaust#510). The fixture declares it, off. - check-steam-library: willfaust#498 declares the audio background mode and moved the grace period to BackgroundRun.shared.beginTask, as check-background-run.py requires. The check now accepts audio as the only background mode and looks for BackgroundRun's task. - check-vis-trace: the count of 73 lists went stale with each new list. It now requires a config for every GameRecommendation (77 today). - check-game-recommendations: the Garry's Mod check (c998a06) also expected hl2.exe to name the game. The list matches App ID 4000, the GarrysMod folder and gmod.exe, as its commit says. hl2.exe is also Half-Life 2's program. The App ID and folder cover both branches. Each check failed before this change and passes after it. Each one also still fails when the production rule it guards is broken on purpose. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: NevesHenry <henriquereisneves@hotmail.com>
With clang 21 (the Swift 6.4.1 toolchain on Linux) the fake-registry run of check-vcrt-arm64-key fails: it counts 14 created keys instead of 2. At -O1 clang turns the harness's init_unicode_string loop into a call to the C library's wcslen. That wcslen counts 4-byte characters, whatever -fshort-wchar says. Every UNICODE_STRING then gets the wrong length, and "\Registry\Machine" is looked up as "\Registry". -fno-builtin keeps the loop as written, as check-hidpad.py already does for the same flags. The run passes with clang 21 and gcc 11, and it still fails when ios_vcrt_arm64_key_publish stops counting the views that are already there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: NevesHenry <henriquereisneves@hotmail.com>
125hz
pushed a commit
that referenced
this pull request
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In short
Eleven host checks fail on main (5fda6a0). In ten of them, production code changed after the check was written (waves 6 to 8 and the merges after them). The eleventh, check-vcrt-arm64-key, is broken by a compiler optimisation. This updates only checks under
tests/host; no app, runtime or build code changes.Details
madeira_audio_background's start condition; 0a2e6ed's render callback also bumpscb_epochin its paused branchcb_epochcompatLabel("Older NVIDIA card (Direct3D 9)", …); 04dda6d, merged after it, expectedcompatLabel(L(…$0.listedInLibrary(0a2e6ed) and$0.gogProductID(fc5e7cb, GOG store) between the conditions the checks looked forpSetCursorPosreports throughwinios_direct_cursor_warpwhen the app has it (0a2e6ed)L()(04dda6d)L(), as check-frontend.py and check-runtime-settings.py doSelf.hiddenCursorAbsolute(#510)BackgroundRun.shared.beginTask(check-background-run.py requires both)GameRecommendationhl2.exeto name the game; the list matches App ID 4000, the GarrysMod folder and gmod.exe, as that commit says, andhl2.exeis also Half-Life 2's programhl2.execlause (App ID and folder cover both branches)init_unicode_stringloop into libcwcslen, which counts 4-byte characters despite-fshort-wchar, so the fake registry created 14 keys instead of 2-fno-builtin, as check-hidpad.py does (separate commit, so it can be dropped)Validation
Linux (Ubuntu 22.04 on WSL2), Swift 6.4.1 toolchain (clang 21), gcc 11, Python 3.10, submodules at the pinned commits.
cb_epoch, itch.io/Epic dropped from the Other games filter, the warp'selseremoved, a second background mode added, Garry's Mod's program removed).compression.zstd); their static checks pass now.AI assistance: prepared with Claude (Claude Code); I reviewed the change and ran the checks. Signed off (DCO).
🤖 Generated with Claude Code