Repository navigation
Fix ICU message format not supported for fallback locale - #378
Merged
Merged
Conversation
monteiro
self-requested a review
March 6, 2026 16:39
monteiro
approved these changes
Mar 6, 2026
AntoineLemaire
added a commit
to Yoopies/BazingaJsTranslationBundle
that referenced
this pull request
Oct 5, 2026
The French fallback was checked right after the exact locale, before the parent locale: on a "de_DE" page, a message missing from the "de_DE" catalogue was translated in French instead of falling back to "de". It is removed, the fallback order is now the upstream one: locale > country > fallback locale (en). translator.js is back to the upstream version. translator.min.js is regenerated: it lacked the ICU locale fallback (willdurand#378). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #332