rename folder

[shubham13695]

Closes #511

[whyboris]

Really cool 🎉 Thank you for the PR 🤝 I'll try it out later today 🏃‍♂️

[whyboris]

After a successful folder rename, do the videos in that folder remain playable?

I feel like unless we update all the paths for the videos in that folder, the videos in that folder will never be playable again (via clicking in the app) 🤔

[whyboris]

WIP spandrel? 🙂

[whyboris]

@shubham13695 -- please let me know if you'd like to address the concern I raised or you'd rather I finish up the feature after merging 👌

At the moment I'm really tempted to get version 3.0.0 released - and this feature could be added after (so there's no rush now).

Thank you again for your contribution 🙇

[shubham13695]

@whyboris yes I address it that after changing the folder on physical directories we need to update that change in our app. I m figuring out how to do it as rightClickElement index return -1 . if you have any idea please share it with me.

[whyboris]

I think this might only need a method in the ImageElementService to update all the objects in the imageElements array 🤔 (replacing the partialPath with the updated version of it).

So once the rename-folder-response comes back to Angular with a success, you would call that method 🤔

[shubham13695]

hi @whyboris
I don't know what wrong with imageElementService.imageElements like before I update the file partial path it already has updated the folder with an older one same thing happening with the video file also.
if i update the same video file twice it create one more file.

[whyboris]

Cool! I checked out your branch -- somehow it creates the new elements (I'll look through your code again -- I didn't realize it did that somehow).

All you'll need to do is mark every element in the old folder path as deleted: true:
https://github.com/whyboris/Video-Hub-App/blob/main/interfaces/final-object.interface.ts#L52

This will prevent the element from being shown - and the element will be removed upon saving the file 🚀

ps - you might need to toggle the deletePipeHack (as I do all over the home.component.ts - to make sure all the deleted no longer show up in the gallery)

this.deletePipeHack = !this.deletePipeHack;

[whyboris]

btw -- if you happen to know -- could you point out how the new elements get created with your code? I'm looking all over your new code and I don't see anything that adds the videos from the new renamed folder into the app gallery - yet the videos do show up 🤯

I don't understand how that happens from your code -- I'm glad that it does, but could you let me know if you happen to know? 😊 😅

[whyboris]

I'm hoping to release version 3.0.0 this week. Because of limited times, and prioritizing the release, I chose not to include this feature in the initial 3.0.0 version.

I look forward to merging it in after a successful release of 3.0.0 🤝

[whyboris]

I'm eager to release version 3.3.0 so this PR will wait for another release 🙇‍♂️

I appreciate the contribution and will try to get it out with a future release 🙇‍♂️

[whyboris]

Related issue #352 👍