Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
commit: |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d68a63d91
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "examples/react-native", | ||
| "examples/tanstack-start", | ||
| "node_modules", | ||
| "site", |
There was a problem hiding this comment.
Add the excluded site to CI validation
The Types job in .github/workflows/verify.yml invokes only the root TypeScript project, so this exclusion prevents every new site module from being type-checked. No workflow invokes the site's check:types or build script either, allowing broken route imports or Cloudflare builds to merge and fail only during deployment. Add explicit site validation to CI before excluding it from the root project.
AGENTS.md reference: AGENTS.md:L170-L172
Useful? React with 👍 / 👎.
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07548b121e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "scripts": { | ||
| "build": "vite build", | ||
| "check:types": "pnpm generate-routes && tsc --noEmit", | ||
| "deploy": "pnpm run build && wrangler deploy", |
There was a problem hiding this comment.
Build the workspace package before deploying the site
From a clean checkout, pnpm --dir site deploy fails during vite build because site/vite.config.ts imports zyzz/vite and the route modules import zyzz/default and zyzz/reset.css, while the workspace package maps those default exports to ignored dist/* files that only the root pnpm build creates. The README performs that prerequisite during initial setup, but the deploy command advertised later does not enforce it and can also deploy stale artifacts after library changes. Make the site build/deploy script build the root package first or explicitly resolve the source exports.
Useful? React with 👍 / 👎.
| color: '#888', | ||
| marginLeft: '20px', | ||
| textDecoration: 'none', | ||
| ':hover': { color: '#ddd' }, |
There was a problem hiding this comment.
Move landing-page selectors into
selectors
The landing page places :hover, :focus-visible, and &[aria-pressed="true"] directly in multiple style objects. Repository authoring rules require string selectors to be grouped under the selectors property, so this new application fixture establishes the wrong contract and will diverge from selector-specific processing as that canonical shape evolves. Move all of these selector blocks under selectors while leaving media queries at the style level.
AGENTS.md reference: AGENTS.md:L197-L197
Useful? React with 👍 / 👎.
Benchmark ReportMount100 cards (static): 🟢 Zyzz (1.03× vs tailwind)
100 cards (overrides): 🟡 Tie: Plain class/style, vanilla-extract (2.10 ms)
100 cards (dynamic): 🔴 Plain class/style (1.02× vs Zyzz)
100 cards (variants): 🔴 Plain class/style (1.06× vs stylex)
1,000 cards (static): 🟢 Zyzz (1.01× vs Plain class/style)
1,000 cards (overrides): 🔴 Plain class/style (1.01× vs vanilla-extract)
1,000 cards (dynamic): 🔴 Plain class/style (1.03× vs Zyzz)
1,000 cards (variants): 🔴 Plain class/style (1.10× vs stylex)
Update100 cards (static): 🟡 Tie: vanilla-extract, Zyzz (1.95 ms)
100 cards (overrides): 🔴 Plain class/style (1.02× vs vanilla-extract)
100 cards (dynamic): 🔴 Plain class/style (1.06× vs Zyzz)
100 cards (variants): 🔴 Plain class/style (1.07× vs stylex)
1,000 cards (static): 🟢 Zyzz (1.00× vs vanilla-extract)
1,000 cards (overrides): 🔴 vanilla-extract (1.02× vs Plain class/style)
1,000 cards (dynamic): 🔴 Plain class/style (1.05× vs Zyzz)
1,000 cards (variants): 🔴 Plain class/style (1.12× vs stylex)
Remount100 cards (static): 🟡 Tie: tailwind, vanilla-extract, Zyzz (1.70 ms)
100 cards (overrides): 🔴 Plain class/style (1.03× vs vanilla-extract)
100 cards (dynamic): 🔴 Plain class/style (1.05× vs Zyzz)
100 cards (variants): 🔴 Plain class/style (1.05× vs stylex)
1,000 cards (static): 🔴 Plain class/style (1.01× vs vanilla-extract)
1,000 cards (overrides): 🟡 Tie: Plain class/style, vanilla-extract (17.30 ms)
1,000 cards (dynamic): 🔴 Plain class/style (1.07× vs Zyzz)
1,000 cards (variants): 🔴 Plain class/style (1.05× vs stylex)
Compile3 Components: 🟢 Zyzz (2.21× vs Tailwind)
1,000 Components : Repeated Styles: 🟢 Zyzz (1.62× vs Tailwind)
1,000 Components : Unique Padding: 🟢 Zyzz (1.06× vs Tailwind)
100 Components : Partial Sharing: 🟢 Zyzz (2.02× vs Tailwind)
100 Components : Reused Palette: 🟢 Zyzz (1.89× vs Tailwind)
100 Components : Independent Values: 🟢 Zyzz (2.39× vs Tailwind)
100 Components : Sparse Properties: 🟢 Zyzz (1.87× vs Tailwind)
60 Components : Mixed Shapes: 🟢 Zyzz (1.98× vs Tailwind)
Themes : 10 Components: 🟢 Zyzz (1.12× vs Zyzz (token resolution included))
Themes : 100 Components: 🟢 Zyzz (1.45× vs Zyzz (token resolution included))
Other resultsBaseline changesCompared with baseline
Extraction, transforms, binding, host, and theme timingsSource Extraction
Module TransformsLiteral Styles
Local Theme Styles
Theme Aliases
Explicit Theme Tokens
Static Props Binding
File Host: 100 Styles
Theme Compilation
|
Added a TanStack Start landing page for Cloudflare Workers with default typography tokens, self-hosted fonts, and global styles in
zyzz.config.ts.Depends on #258.