Repository navigation
feat(zbugs-rune): follow zbugs-swift's macOS layout - #169
Merged
Merged
Conversation
The sidebar is one card of labeled rows (Status, Sort, Order, the Created by Me and Assigned to Me switches, Creator, Assignee, Labels, Project). The connection and the account (Log Out or Log In, Servers) move to the list header, which shares the titlebar's band with the detail's toolbar: close or reopen, edit and delete as icons, then the search. Rows lead with the open or closed circle and read "#id · creator · time"; the issue's pickers sit in one row under its status line. Amp-Thread-ID: https://ampcode.com/threads/T-01a1c85e-fd3c-72ba-98dd-f4767a00e73b Co-authored-by: tmm <tmm@tmm.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Rune zbugs app now follows zbugs-swift's macOS layout (
apps/zbugs-swift/Sources/ZBugsUI), so the Swift, GPUI and Rune apps share one layout. Exact pixels and colours stay Rune-native.What moved
Sidebar: one card of labeled rows, with the label on the left and the value on the right:
The connection badge, Log Out and Servers… are no longer in the sidebar.
List header, in the titlebar band: "Open Issues", the count, the connection dot and "Connected" (pressing it reconnects now, and its tooltip shows the server or the error), and icon buttons for Select and New Issue. Last comes the account menu: "Logged in as … (role)", Log Out (or Log In…), and Servers….
Rows: the open circle (green) or closed check (purple), the title, then "#id · creator · time" and the label chips. The unread dot stays.
Detail: close or reopen, edit, and delete are toolbar icons, with search at the right of the band. Below them come the title, "Open by …" (with "· Internal" when internal), and then the assignee, visibility and notifications pickers in one compact row. The labels, body, reactions, comments and comment box follow.
The three headers share a 52-point titlebar band (
rune::Titlebar) that drags the window. The sidebar's band keeps clear of the traffic lights.New
src/icons.rsdraws the SF Symbols that Swift uses as SVG icons.Screenshots
macOS, headless with Rune's renderer at 1180×760, against zbugs' backend, with rocicorp#3005 selected.
Checks
cargo fmt --check,cargo clippy --all-targets --locked -D warningsandcargo test --lockedpass.e2e.shpasses all 8 checks (comment edited, reaction, labels, closed, internal, unsubscribed, viewed, comment on screen). The keys it taps (toggle-open,labels-trigger,visibility-trigger,notifications-trigger, …) are unchanged.No changes to
rust/orapps/zbugs-model.