Repository navigation
feat(zbugs-gpui): Escape clears the search, as in zbugs' list - #166
Merged
Merged
Conversation
Co-authored-by: tmm <tmm@tmm.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the web list, Escape in the search box clears the search (
handleSearchKeyUp→clearAndHideSearch). The GPUI search field already had a clear (×) button, but Escape did nothing. Now the searchInputStateusesclean_on_escape(), so Escape empties the field, which refilters the list like any other edit.Checked on macOS: searching for
websocketunder Creator: cesara shows no issues, and Escape empties the field and brings back the 3 issues. Clippy is clean with and withoute2e.