Repository navigation
feat(zbugs-gpui): title the window as zbugs titles its pages - #165
Merged
Merged
Conversation
"Zero Bugs → " and the shown issue's title, or the list's: Open, Closed, All, or Filtered Issues. Co-authored-by: tmm <tmm@tmm.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The web app sets
document.titletoZero Bugs → <issue title>on the issue page andZero Bugs → <list title>on the list (Open Issues,Closed Issues,All Issues, orFiltered Issueswhen a creator, assignee, label, or search filter is set). The GPUI window was always titled "Zero Bugs". Now it follows the same rule: the shown issue's title, or the list's when no issue is shown. The window title is set only when it changes, which keeps it accurate in the Window menu, Mission Control, and ⌘`.Checked on macOS: with rocicorp#3000 shown, System Events reports the window's name as
Zero Bugs → Leaking listeners on AbortSignal. Clippy is clean with and withoute2e, and the end-to-end run passes online and offline.