Repository navigation
feat(zbugs-gpui): search the user and label pickers - #164
Merged
Merged
Conversation
The creator, assignee, and label filters and the issue's assignee and labels open a list with a search field, as zbugs' comboboxes do: ranked as its fuzzySearch, with avatars for users, arrow keys and Enter to pick, and the label pickers stay open to pick several. Co-authored-by: tmm <tmm@tmm.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The web app's creator, assignee, and label pickers are comboboxes you can type into. zbugs-gpui showed plain scrolling menus. Now those five pickers (the Creator, Assignee, and Labels filters, and the issue's assignee and labels) open a popover with:
fuzzySearch(the start of a name counts most, then runs of characters; ties sort by name), with a unit test;The short pickers (project, notifications, visibility) keep their menus. The new code is
src/picker.rs, inside the app.Choicemoved there and gained anavatar.Checked on macOS: typing
arin Creator ranks arv first, then cesara, darkgnotic, ingar, and jamischarles. Down then Enter filters to cesara. Typingpein an issue's Labels and pressing Enter adds papercut and leaves the picker open. Clippy is clean with and withoute2e,cargo testpasses, and the end-to-end run passes online and offline.