You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Measure edge pointers before the geometry reuse check so DesiredSize changes invalidate the cached geometry on the first pass. Add a regression test that changes pointer size between measures and verifies the edge geometry is rebuilt immediately.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This reuse key is incomplete for the geometry that is skipped below: UpdateConnectionPoints also consumes OverrideEndpoint and the edge's source/target connection-point IDs, while UpdatePoints/PrepareEdgeLayout consume the graph routing settings and ReversePath. For example, EdgeControl.Drag changes OverrideEndpoint and only invalidates measure; with the same vertex rects and route this check returns true, so the preview edge keeps its old endpoint. Include every input used by the skipped geometry computation (or explicitly invalidate/reset this cache when those inputs change).
This issue also appears on line 1374 of the same file.
CheckGeometryReusability was missing several inputs consumed by the geometry recompute path it gates: OverrideEndpoint, source/target connection-point IDs, ReversePath, and the graph's edge-routing settings (IsEdgeRoutingEnabled/EdgeCurvingTolerance). Changing any of these without also changing vertex rects or the route could leave the reuse path returning true and skip recomputing points/geometry.
Also add an explicit reversePathChanged dirty-flag check in UpdateCacheInfo: ReversePath only reverses traversal order when the final StreamGeometry is built and never mutates the cached point values, so the existing point-value comparison alone cannot detect a ReversePath-only change.
Add a regression test covering the ReversePath case.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.