Performance Refactor for the CodeGen, and readability cleanup - #29
Merged
Merged
Conversation
The 'Performance regression check' job embedded in build.yml (Build and Test workflow, triggers on every PR) was a leftover duplicate of the dedicated benchmark.yml workflow created later. It still used the unpatched rhysd/github-action-benchmark@v1 with no auto-push/skip-fetch-gh-pages config, so its second github-action-benchmark invocation always failed with a non-fast-forward git fetch on gh-pages (the same two-invocations-in-one-job race already fixed in benchmark.yml). benchmark.yml already covers publishing benchmark results on push to main, so this duplicate job is removed rather than re-patched. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Wires up the previously-unused FeatureRichIncrementalScenario/ IncrementalGeneratorScenario infrastructure to 5 new [Benchmark] methods: Incremental_NoOpRerun, Incremental_UnrelatedEdit, Incremental_InjectedSignatureEdit, Incremental_AddInjection, and Incremental_ReferenceAssemblyChange. These measure whether IDE-editing (re-run on a warmed GeneratorDriver) recomputation is well-incrementalized, as opposed to the existing Cold_* benchmarks which only measure first-run cost. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
FindMethods checks type.AllInterfaces for [Inject] in addition to a type's own attributes, and InjectAttribute's AttributeUsage explicitly allows AttributeTargets.Interface - meaning a class can be discovered for injection purely because it implements an [Inject]-attributed interface, without [Inject] on the class itself. This pre-existing behavior had zero test coverage. Added GeneratorPicksUpClassesViaAttributeAppliedToImplementedInterface to pin it down before any future refactor of the type-discovery pipeline (e.g. a ForAttributeWithMetadataName-based incremental rearchitecture) could silently regress it. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.