Repository navigation
fix(client): bump lockgate to v0.2.1 to avoid deadlock at lock timeout boundary - #434
Merged
Merged
Conversation
…t boundary lockgate pollLock could crash the process with "all goroutines are asleep - deadlock!" when the file lock was acquired in the same instant the lock timeout expired. Observed on shared GitLab runners where several trdl processes contend for the configuration lock. Signed-off-by: Aleksei Igrychev <aleksei.igrychev@palark.com>
Signed-off-by: Aleksei Igrychev <aleksei.igrychev@palark.com>
Signed-off-by: Aleksei Igrychev <aleksei.igrychev@palark.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trdl use/trdl addcould crash withfatal error: all goroutines are asleep - deadlock!when the configuration file lock was acquired in the same instant its 30s timeout expired. Seen on shared GitLab shell runners where several trdl processes contend for~/.trdlwhile one of them holds the exclusive lock during a slow network call.Root cause and fix are in lockgate: werf/lockgate#49 (released as v0.2.1). This PR only bumps the dependency (
gofrs/flockmoves to v0.13.0 transitively).Checks:
go build ./... && go vet ./pkg/... && go test ./...inclient/— green.