fix: correct miscelaneousFields typo in EncodingData - #391
Merged
Conversation
EncodingData::miscelaneousFields was missing an 'l'. The class it holds, MiscellaneousField, and every core-side name were already spelled correctly, so the member was the lone outlier. Breaking: the member is public mx::api. Callers using the old spelling must rename. No alias is left behind, matching the ScoreData layout -> defaults rename in v0.5.0.
Follows the miscellaneousFields rename with the other misspellings a dictionary pass over the identifiers turned up. All are private mx::impl names or comment text, so nothing here is breaking. TechnicalFunctions had the same word misspelled two different ways while the class itself was spelled correctly: parseTechicalMark and its techicalChoice parameter dropped the 'n', and the constructor parameter inTechincalChoiceSet and member myTechincalChoiceSet transposed it. MeasureReader's isUserRequestedVoiceNumberConsistentAccrossAllVoices had a doubled 'c'. Comment fixes in public headers: alyways, convient, otherwords, and Clarient in the TransposeData doc table. SoundID.h is deliberately untouched. brass.sackbutt and strings.violono.piccolo mirror the MusicXML standard sound-id strings and must match the wire format.
webern
approved these changes
Aug 7, 2026
webern
left a comment
Owner
There was a problem hiding this comment.
Those were the good old days of slamming stuff out by hand!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human Summary
miscellaneousFields.Summary
Two commits. The first is the field rename; the second sweeps up the other misspellings a dictionary pass over the identifiers turned up.
EncodingData::miscelaneousFields->miscellaneousFieldsMissing an
l. The class the vector holds,MiscellaneousField, was already spelled correctly, as arecore::Miscellaneous,core::MiscellaneousField, and the<miscellaneous-field>element itself, so this member was the lone outlier. Eight occurrences in five files: the declaration and itsMXAPI_EQUALS_MEMBERline, the reader and writer, and two test score-data builders.Breaking: the member is public
mx::api, so callers using the old spelling must rename. No compatibility alias is left behind, matching how theScoreDatalayout->defaultsrename was handled in v0.5.0.Other misspellings
Checking whether any sibling had the same problem meant spell-checking every identifier in the tree. It was the only misspelled public field name, but four other things turned up. None is breaking -- they are private
mx::implnames and comment text.TechnicalFunctionshad the same word misspelled two different ways, while the class itself was spelled correctly:parseTechicalMarkand itstechicalChoiceparameter dropped then, and the constructor parameterinTechincalChoiceSetand membermyTechincalChoiceSettransposed it.MeasureReader::isUserRequestedVoiceNumberConsistentAccrossAllVoiceshad a doubledc.Comment fixes in public headers:
alyways,convient,otherwords, andClarientin theTransposeDatadoc table, which is rendered documentation. The table is column-aligned andClarinetis the same width, so the alignment holds.SoundID.his deliberately untouched.brass.sackbuttandstrings.violono.piccololook wrong but mirror the MusicXML standard sound-id strings and have to match the wire format.The rename in
TechnicalFunctions.cpplengthened a signature by one character, somake fmtreindented that function's continuation lines. That is the only non-rename change in the second commit.Testing
make api-roundtrippasses (364 of 364 pinned)make core-roundtrip-testpasses (839 test cases)make fmt-checkclean on touched filesgrepfor every corrected spelling returns nothing outsidecore/generatedRenames only -- no behaviour change, so no new tests. The existing
ApiK016aMiscandApiLy43esuites already exercise the renamedEncodingDatamember on both the read and write paths, and the technical-mark and voice-number paths are covered by the api suite.