feat: add a v10 transform for legacy command signatures - #140
Open
christian-bromann wants to merge 1 commit into
Open
christian-bromann wants to merge 1 commit into
christian-bromann wants to merge 1 commit into
Conversation
Rewrite boolean addCommand and overwriteCommand scopes, getHTML(boolean), and string getCookies or getCookie filters into the v10 options objects.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
v10jscodeshift transform for the mechanical command-signature changes in webdriverio/webdriverio#15655:addCommand/overwriteCommandboolean scope becomes{ attachToElement }getHTML(true|false)becomesgetHTML({ includeSelectorTag })getCookies('name'),getCookies(['name']), andgetCookie('name')becomegetCookies({ name })A
getCookiescall with more than one name is left unchanged.Companion runtime change: webdriverio/webdriverio#15712
Test plan
npm test(babel and tsx parsers, including the new v10 fixture)