Repository navigation
Conversation
|
Thank you for your contribution! The team is still discussing and thinking through the implementation approach. We’ll share any updates or continue the discussion here once we make progress! |
Thanks for the update! Once the approach is settled, I’d be happy to update this PR accordingly and help with the remaining work in #1291 if needed. |
|
Hi, sorry for delay. I personally agree with the implementation approach. I have a few thoughts on this topic:
Do you have any thoughts or feedback on these points? Would you be open to me continuing the work directly on your PR? |
|
Thanks for the detailed review — this is really helpful.
And yes, please feel free to continue directly on this PR — maintainer edits are already enabled! I’m quite busy with work at the moment and don’t have much time to continue this myself, so I really appreciate your offer to help. |
|
@elecmonkey I've signed the CLA 🥰 |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
360c17f to
81fbf56
Compare
81fbf56 to
50fe5eb
Compare
50fe5eb to
b803fd7
Compare
|
I accidentally clicked “Update branch” while looking through your changes, which triggered another CI approval request. Sorry for the extra step😣, and thanks again for continuing the work on this PR!❤️ @elecmonkey |
Motivation
Keeping the
exportsfield inpackage.jsonin sync with build entries is manual and error-prone, especially for multi-entry or dual-format libraries. #1291 proposes generating it from build outputs.Changes
Add opt-in exports generation through
rslib build --exports, theexportsconfiguration option, and the JavaScript build API. After a successful build, Rslib generates exports for ESM and CJS entries, declaration files, and bundled CSS.The configuration supports selecting entries, exposing source files for development, and customizing the generated result. Generated exports replace the existing
exportsfield; they are not written in watch mode or when building only selected libs.The release management guide documents the generation rules and options.