Conversation
|
Deployment previews on netlify for branch
|
dati18
marked this pull request as ready for review
July 27, 2026 11:28
Contributor
Author
tarrow
reviewed
Jul 28, 2026
tarrow
reviewed
Jul 28, 2026
tarrow
reviewed
Jul 28, 2026
dati18
approved these changes
Jul 29, 2026
**CHANGES** 1. `HostingPolicyRenderer.vue` - Replaced banner condition from computed date logic to route/API - Removed `isFutureDate` helper - Added `isCurrentRoute` + `policyType` parity with `TermsOfUseRenderer` 2. `PolicyNavigationPanel.vue` - Removed date parsing/comparison helpers - Added API-driven state fields `currentPolicyId` and `upcomingPolicyId` - Links now resolve current/upcoming via those IDs from API responses instead of local date logic - loadPolicies now fetches: - all policies - current policy (via `getCurrentPolicyByType`) - upcoming policy (via `getUpcomingPolicyByType`, with 404 handled as “none”) Bug: T432965 Co-authored-by: Thomas Arrow <thomas.arrow@wikimedia.de>
A rather unelegant workaround to handle the case of no currrent hosting policy to redirect people to the pilot. This allows us to change the footer link to be just '/hosting-policy' and have it handled by the HostingPolicyRenderer but still redirect to the pilot component. Added comments to ensure we remove this cruft as soon as the pilot policy is redundant. Bug: T432965
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: T432965