Repository navigation
Conversation
10_FactoryProgram builds the image in firmware/ (its app descriptor names project 03_Fac). CI now builds it as the factory firmware with ESP-IDF v5.5.5 instead of as an example.
Contributor
Author
|
CI passed (23 pass, including build-factory-firmware from examples/factory). Closing: this change goes in through GitLab MR !9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI-only PR, to be closed without merging. The source of truth is the internal GitLab (MR !9);
mainreaches GitHub through the mirror.git mv examples/esp-idf/10_FactoryProgram examples/factory. The image infirmware/was built from this project (its app descriptor names project03_Fac, the same asproject()in itsCMakeLists.txt)product.jsonadds"factory_firmware": { "esp_idf": "v5.5.5" }, so CI builds it as the factory firmware rather than as an example