🔧 update: simplify build script by removing unnecessary flag - #6
Merged
Conversation
🔀 Pull Request BuildPre-release package for testing PR changes 📦 Package Information
📥 Installation InstructionsNPM Registrynpm install github-labels-template@0.9.2-pr.1ceac3f
npm install github-labels-template@pr # Use dist-tagGitHub Packagesnpm install @warengonzaga/github-labels-template@0.9.2-pr.1ceac3f
npm install @warengonzaga/github-labels-template@pr # Use dist-tag✨ Auto-scoped as 🔒 Security Audit✅ No vulnerabilities found This package was built automatically by the Package Build Flow action. |
🔀 Pull Request BuildPre-release package for testing PR changes 📦 Package Information
📥 Installation Instructions🔒 Security Audit✅ No vulnerabilities found This package was built automatically by the Package Build Flow action. |
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s Bun build command by removing the --packages external flag in package.json, aiming to simplify the build pipeline for the Node-targeted CLI distribution.
Changes:
- Updated the
buildscript to drop--packages externalfrom thebun buildcommand.
| ], | ||
| "scripts": { | ||
| "build": "bun build src/index.ts --outfile dist/index.js --target node --packages external", | ||
| "build": "bun build src/index.ts --outfile dist/index.js --target node", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR simplifies the build script by removing an unnecessary flag, which helps streamline the build process and reduces complexity.
Changes
--packages externalflag from the build script inpackage.json.Test Plan