🔧 update: move to node.js as runtime engine - #4
Conversation
🚀 Development BuildDevelopment version ready for integration testing 📦 Package Information
📥 Installation InstructionsNPM Registrynpm install github-labels-template@0.9.0-dev.b3751b3
npm install github-labels-template@dev # Use dist-tagGitHub Packagesnpm install @warengonzaga/github-labels-template@0.9.0-dev.b3751b3
npm install @warengonzaga/github-labels-template@dev # Use dist-tag✨ Auto-scoped as 🔒 Security Audit✅ No vulnerabilities found This package was built automatically by the Package Build Flow action. |
🚀 Development BuildDevelopment version ready for integration testing 📦 Package Information
📥 Installation InstructionsNPM Registrynpm install github-labels-template@0.9.0-dev.12d5215
npm install github-labels-template@dev # Use dist-tagGitHub Packagesnpm install @warengonzaga/github-labels-template@0.9.0-dev.12d5215
npm install @warengonzaga/github-labels-template@dev # Use dist-tag✨ Auto-scoped as 🔒 Security Audit✅ No vulnerabilities found This package was built automatically by the Package Build Flow action. |
There was a problem hiding this comment.
Pull request overview
This PR updates the project to standardize on Node.js (>=26) as the runtime while continuing to use Bun for building/testing, and adjusts scripts/docs/CI accordingly.
Changes:
- Bump the minimum Node engine requirement and CI Node version to
26. - Update
package.jsonscripts to build with Bun and execute the built CLI with Node. - Add Node typings and update docs to describe the Node runtime + Bun toolchain approach.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
tsconfig.json |
Adds Node types alongside Bun types for TypeScript. |
README.md |
Updates feature messaging and adds runtime note for Node execution. |
package.json |
Updates scripts to run compiled output with Node; bumps Node engine; adds @types/node. |
CONTRIBUTING.md |
Updates prerequisites and local run instructions for “build then run with Node”. |
bun.lock |
Lockfile updates reflecting added Node typings and dependency resolution. |
.github/workflows/package.yml |
Updates CI to use Node 26. |
Comments suppressed due to low confidence (1)
README.md:288
- The added note recommends “Node.js (latest)”, but
package.jsonnow requires Node>=26. Consider making the README guidance explicit (e.g., “Node.js 26+”) to avoid confusion for contributors/users.
migrate Wipe all existing labels and apply the template (clean slate)
generate Generate custom labels using AI (requires GitHub Copilot)
| @@ -21,7 +21,7 @@ A CLI tool to apply a curated set of GitHub labels to any repository using `gh` | |||
| - 📊 **Clear Output**: Structured logging powered by [@wgtechlabs/log-engine](https://github.com/wgtechlabs/log-engine) with color-coded levels and emoji | |||
| - 🎨 **ASCII Banner**: Beautiful ANSI Shadow figlet banner with version and author info | |||
| "preview": "bun src/index.ts preview", | ||
| "dev": "bun run build && node dist/index.js", | ||
| "preview": "bun run build && node dist/index.js preview", | ||
| "start": "node dist/index.js", |
| "engines": { | ||
| "node": ">=18", | ||
| "node": ">=26", | ||
| "bun": ">=1.0" |
|
|
||
| ## Prerequisites | ||
|
|
||
| - [Node.js](https://nodejs.org) (latest) |
|
@copilot apply changes based on the comments in this thread |
Agent-Logs-Url: https://github.com/warengonzaga/github-labels-template/sessions/860b269f-378d-438d-abd8-7e81063bb9cf Co-authored-by: warengonzaga <15052701+warengonzaga@users.noreply.github.com>
Implemented all requested updates in commit e5cbc00: Quick Start now uses Node-based commands (removed Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This pull request updates the project to use the latest Node.js runtime (v26+) and adjusts documentation, scripts, and configurations to clarify that the toolchain uses Bun for building and Node.js for execution. It also updates development scripts for a more standard workflow and improves type safety in development.
Runtime and Toolchain Updates
.github/workflows/package.ymlandpackage.jsonto26or higher, ensuring all builds and executions use the latest Node.js runtime. [1] [2]README.mdandCONTRIBUTING.mdto clarify that the tool is built with Bun but runs on Node.js, replacing references to dual runtime (npx/bunx) with the new approach. [1] [2] [3]Development Workflow Improvements
package.jsonscripts so thatdev,preview, andstartcommands build with Bun and execute with Node.js, providing a more consistent and reliable development experience.CONTRIBUTING.mdto reflect the new build and run steps using Node.js after building with Bun.Type Safety Enhancements
@types/nodeas a development dependency to improve type safety and editor support when working with Node.js APIs.