Conversation
tree-sitter comes from the optional `analysis` extra and the binaries are system installs, so these tests failed on any machine without them. CI installs all three, so coverage there is unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011FeZUmAZbyQWDJNAPkUA3S
`make test` runs `.venv/bin/python -m pytest`, which leaves the venv's bin directory off `PATH`. The adopt smoke test then ran a different `python3`, and the environment test could not find the `pytest` script. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011FeZUmAZbyQWDJNAPkUA3S
MrJoy
marked this pull request as ready for review
September 28, 2026 19:17
There was a problem hiding this comment.
Confidence Score: 5/5
Summary
Removes local-tool and virtualenv assumptions from tests without changing production behavior. Low risk; the full-dependency suite passed 2,375 tests with two optional Rust-parser skips.
Important Files Changed
| File | Overview |
|---|---|
| tests/test_adopt.py | Runs generated smoke tests using the current interpreter |
| tests/test_environment.py | Adds the interpreter’s scripts directory to PATH with fixture-scoped cleanup |
| tests/test_tool_index.py | Skips tool-dependent tests when their required binaries or Python packages are unavailable |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nine tests failed on a clean
maincheckout when run the waymake testruns them (.venv/bin/python -m pytest, venv not activated) with.[dev,all-backends]installed.test_tool_index.pytree-sitter tests (TestDetectTools::test_detects_tree_sitter, four inTestTreeSitter,TestIntegration::test_build_tool_index_real): tree-sitter comes from the optionalanalysisextra. They now skip without it and all pass with it installed.TestDetectTools::test_detects_cscope: needs thecscopebinary. Skips when it is not onPATH.ctagstests (test_detects_ctags,TestCtags, the twoTestIntegrationtests): pass here, but fail on a Mac that only has BSD/usr/bin/ctags. They skip unless universal-ctags is present. CI installsuniversal-ctagsandcscopeand theanalysisextra, so nothing is skipped there.test_adopt.py::TestAdoptDryRun::test_smoke_tests_are_runnable: test bug. It ranpython3fromPATH, which was a different interpreter without pytest. Now usessys.executable.test_environment.py::TestEnvironmentSpec::test_validate_finds_pytest: test assumed the venv's scripts directory was onPATH. It now prependssysconfig.get_path("scripts")viamonkeypatch.test_cache_threading.pyandtest_research_sharing.pyare unchanged. They failed only in the original checkout, and they failed every time there, because stale__pycache__bytecode still carried the old~/wander/pactpaths from before the repo moved. After deleting__pycache__, both pass. Not a code or test bug..[dev,all-backends]:.[dev,all-backends,analysis]:The remaining skips are
cscope(not installed on this machine) and twotree_sitter_rusttests, which theanalysisextra does not provide.🤖 Generated with Claude Code
https://claude.ai/code/session_011FeZUmAZbyQWDJNAPkUA3S
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.