Repository navigation
Skip translations without a URL in the language selector (#511) - #529
Open
rohitmulani63-ops wants to merge 1 commit into
Open
rohitmulani63-ops wants to merge 1 commit into
rohitmulani63-ops wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #511
Description
So the problem is that the link becomes
href="None", so now the language menu skips languages that have no page.Testing
test_translation_without_url_is_omittedinapps/core/tests/test_language_selector.pyAI usage
Yes, Claude was used, but under my supervision. All tests pass on my fork's test run.