Repository navigation
Propagate active call cancellation into component host imports - #29
Merged
Joshua Tenner (jtenner) merged 2 commits intoOct 5, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Component host callbacks currently inherit the context used to instantiate the component. Canceling a later
Instance.Calltherefore does not cancel a blocking host import, and a retained callback context remains live after its invocation ends.This change lazily obtains the active invocation context for direct and forwarded host imports, while preserving instance context values and caller identity. The first commit proves the lost cancellation and deadline; the second fixes it.
Validation: full tests, full race suite, vet, Go 1.22, Windows/macOS builds, and component fixture validation. Independent review approved tree
00ce741c938f1e79aeddf77b90e05643d2ba096f; the published tree is identical. Unqueried callbacks improve from 10 to 9 allocations per call. Querying cancellation uses 11 rather than 10 allocations for the scoped resolver state.