Skip to content

Drain host resources when graph initialization fails - #28

Merged
Joshua Tenner (jtenner) merged 2 commits into
mainfrom
codex/component-initialization-resource-rollback
Oct 5, 2026
Merged

Joshua Tenner (jtenner) merged 2 commits into
mainfrom
codex/component-initialization-resource-rollback

Conversation

@jtenner

@jtenner jtenner commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add a red component fixture that acquires two owned host resources before initialization fails
  • drain live resources before closing core modules on the graph failure path
  • preserve the original setup error when cleanup succeeds and join cleanup failures when needed

Commit structure

  1. test: reproduce host resource leaks during graph initialization failure (red)
  2. fix: drain host resources when graph initialization fails (green)

Validation

  • focused race tests ×30
  • full tests, full race suite, and go vet ./...
  • Go 1.22 and Windows/Darwin compilation controls
  • downstream WASI integration and original preopen cleanup regression
  • independent review: APPROVE at e067af7fd38d35ccf4599183ccef8aa0953eeacd
  • successful initialization unchanged; successful failure cleanup preserves error identity and adds no errors.Join allocation

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-05T09:54:17.470312Z e067af7 PR opened
🔒 Security Review ✅ Completed 2026-10-05T09:57:31.031441Z e067af7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jtenner
Joshua Tenner (jtenner) merged commit 1c91a0e into main Oct 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant