Repository navigation
Add support for the component model map<K, V> type - #26
Open
Andrew Steurer (asteurer) wants to merge 3 commits into
Open
Andrew Steurer (asteurer) wants to merge 3 commits into
Andrew Steurer (asteurer) wants to merge 3 commits into
Conversation
Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>
Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>
Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for the component model
map<K, V>type (defvaltype tag0x63). The canonical ABI formap<K, V>is the same as forlist<tuple<K, V>>, which meant that I was able to reuse/mirror much of the existing list code.I confirmed everything works by running
go test ./...in the root of the repo.Conformance
binary__binary__0090__L953, wasmtimemap-types__0000__L3.canon liftmemory option from a different core instance is not honored. New entries for this have been added to xfail.