Repository navigation
fix: added trap for non-aligned list pointers - #25
Merged
Jairus (JairusSW) merged 1 commit intoOct 1, 2026
Merged
Jairus (JairusSW) merged 1 commit into
Jairus (JairusSW) merged 1 commit into
Conversation
Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>
Member
|
looks good, thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce realloc pointer alignment when lowering lists
Fixes upstream conformance test
values__realloc__0006__L93/action/L94.When lowering a
list<T>into a component's memory, Wago calls that component's realloc canon option and doesn't check whether it was aligned toT's alignment, so a realloc returning e.g. 2 for alist<u32>doesn't trap.allocStoreList(internal/abi/memory.go) now rejects a misaligned pointer immediately after realloc and before the bounds check. This matches the Canonical ABI's store_list_into_range, where erroneous alignments trap immediately after the pointer is assigned.Unchanged