ci: termlens-cli is on crates.io; make the next release say so honestly - #294
Merged
Conversation
Published 0.10.0 on 2026-09-08 through the publish-cli.yml bootstrap, and verified the way a user meets it rather than from this tree: `cargo install termlens-cli --locked` from the registry, then `inspect` driving a real PTY, `diff` exiting 1 on a difference, `render --svg` and `--ansi`. That changes what release.yml does next time, and not for the better unless it is handled. The step guarded itself with "does crates.io know this crate?" and skipped with a warning; crates.io now answers 200, so it will run — and Trusted Publishing is configured *per crate*, so the OIDC token minted for `termlens` does not carry `termlens-cli` until that crate has a publisher of its own. The failure would be a bare 403, arriving after `termlens` is already published, which is the worst moment to be cryptic. The step now says what is almost certainly wrong, where to fix it, and warns that re-running the job will fail on the other crate instead. RELEASING.md said publishing stores no secret anywhere. That is currently false — CARGO_REGISTRY_TOKEN exists for exactly one bootstrap — so the prerequisites now list both crates, mark termlens-cli as not yet linked, and carry the teardown: link it, revoke the token, delete the secret, delete the workflow. Its "first publish" section is now a general recipe for a brand-new crate rather than a to-do. Refs #255 Signed-off-by: Vyncint Ng <115854244+vyncint@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
termlens-cli 0.10.0is published (2026-09-08, via thepublish-cli.ymlbootstrap). Verified the way a user meets it, not from this tree:The reason this is a PR and not just a report.
release.yml's CLI step guarded itself with "does crates.io know this crate?" and skipped with a warning. crates.io now answers 200, so next tag it will run — and Trusted Publishing is configured per crate, so the OIDC token minted fortermlensdoes not carrytermlens-cliuntil that crate has a publisher of its own. The failure would be a bare 403, arriving aftertermlensis already published. The step now names the likely cause, the exact place to fix it, and warns that re-running the job fails on the other crate instead.docs/RELEASING.mdclaimed publishing stores no secret anywhere; that is currently false, so the prerequisites now list both crates, marktermlens-clias not yet linked, and carry the teardown. Its "first publish" section becomes a general recipe for bootstrapping a brand-new crate rather than a to-do item.Still yours to do (needs a crates.io login, so I can't): link Trusted Publishing for
termlens-cli→ crates.io → termlens-cli → Settings → Trusted Publishing → GitHub, repositoryvyncint/termlens, workflowrelease.yml, environmentrelease. Say the word afterwards and I'll deletepublish-cli.ymland its zizmor entry; you delete theCARGO_REGISTRY_TOKENsecret. I've deliberately not removed the workflow yet — until the link exists it is the only working path for atermlens-clirelease.Refs #255