build(deps): bump signal-hook from 0.3.18 to 0.4.4 - #101
Conversation
Bumps [signal-hook](https://github.com/vorner/signal-hook) from 0.3.18 to 0.4.4. - [Changelog](https://github.com/vorner/signal-hook/blob/master/CHANGELOG.md) - [Commits](vorner/signal-hook@v0.3.18...v0.4.4) --- updated-dependencies: - dependency-name: signal-hook dependency-version: 0.4.4 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
3f88131 to
8b1bf86
Compare
|
Reviewed and not merging this one — it costs a duplicate crate and buys nothing today. What the lockfile in this diff actually says
Today there is one copy, shared: $ cargo tree -i signal-hook --depth 3
signal-hook v0.3.18
├── crossterm v0.29.0
│ └── ratatui-crossterm v0.1.2
│ └── ratatui v0.30.2
├── mossaic v0.8.0
└── signal-hook-mio v0.2.5
└── crossterm v0.29.0 (*)crossterm 0.29 pins Why that matters more than usual hereThe comment immediately above the line this PR edits is the rationale for the version:
Being already in the tree is why 0.3 was chosen. Merging this would quietly falsify the comment explaining the choice, which is the kind of drift that survives for years because nothing checks it. What would justify it
Nothing wrong with the PR itself; the bot is doing its job. Closing so it stops being re-proposed weekly, and telling Dependabot to hold this major until there is a reason. @dependabot ignore this major version |
|
Closing per the review above — held until crossterm moves to signal-hook 0.4, at which point the bump costs nothing. |
|
OK, I won't notify you about version 0.x.x again, unless you re-open this PR. |
Bumps signal-hook from 0.3.18 to 0.4.4.
Changelog
Sourced from signal-hook's changelog.
... (truncated)
Commits
f37a7b5Document SIGBUSb089b6bUpdate deps7854fb6Don't exclude .c files from release packagec81b0e0Release version 0.4.2390dafbFix double-close on pipe unregister173107aExclude development script from published package2413101Release async crates85f8c75Version 0.4.1 (don't pin dep versions)6e44722Version bump to 0.4.080cc0cfUpdate dependencies