Repository navigation
ci: share analysis between pushes and unreleased spec builds - #59
Merged
Merged
Conversation
Pushes were downloading openapi-3.0.yaml from the latest stable release, which still publishes the legacy bundles. Specification builds already have the unreleased artifact, so generation stays on that called workflow.
The example imports a gitignored credentials file, and the Flutter example is a separate app.
The analyzer no longer needs a credentials file to exist.
dart pub get already resolves example/ when it exists.
The example package has to be pub-gotten too, or its own libraries do not resolve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openapi-3.0.yamlfrom the latest stable specification release. Analysis runs on pushes tomainand on pull requests.ci.yaml, which generates from the unreleased bundle artifact and then runs that same Analyze workflow.openapi-3.0.yamlfrom the release that triggered it. A manual run uses the nightly bundle, which can be overridden with a URL.Test plan
dart analyzeand pana) without a generate jobbuild_dart(generate, then analyze and pana)openapi-3.0.yamland runs./generate.sh local