Repository navigation
Describe scheme variants in the versioning docs - #10747
Conversation
The compression section described per-edition scheme configuration as planned work. The decimal, bit-packing and frame-of-reference schemes now pick their v1 or v2 variant from the allowed wire IDs (#10076), so the section and the compatibility footnote describe that behavior instead. The section also names the frame-of-reference exception for child compression. Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Merging this PR will degrade performance by 1.37%3 warnings, 1 note
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
| does not exclude it. For example, the CUDA preset excludes the v2 IDs described below. The | ||
| compressor excludes a scheme if any wire ID that the scheme declares is not allowed. Child arrays go | ||
| through the same compressor, except that the frame-of-reference scheme always bit-packs its encoded | ||
| child with the v1 bit-packing variant. The writer still checks every serialized ID, so a forbidden |
There was a problem hiding this comment.
would remove the frame-of-reference reference bc it should support v2 bitpacked variant as well
| child with the v1 bit-packing variant. The writer still checks every serialized ID, so a forbidden | ||
| ID in any child fails the write. | ||
|
|
||
| The decimal, bit-packing, and frame-of-reference schemes each have a v1 and a v2 variant. The |
There was a problem hiding this comment.
is this necessary to include? This will change. Should just add an example.
There was a problem hiding this comment.
Replaced the list with the decimal scheme as the one example in 98119a5, so the text does not go stale as more schemes gain variants.
Drops the list of schemes with variants, which will change, and the frame-of-reference exception for child compression, which #10751 tracks as a bug. Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Summary
The compression section of the versioning design still described per-edition scheme configuration as planned work, and said that the decimal scheme only declares the v1 wire ID. Since #10076, the decimal, bit-packing and frame-of-reference schemes pick their v1 or v2 variant from the allowed wire IDs. The section and the compression footnote of the compatibility page now describe that behavior, with the decimal scheme as the example. A v2 variant also writes the v1 ID, so a writer must allow both IDs to use it.
🤖 Generated with Claude Code