Skip to content

Attach RowFn validity directly to canonical output - #10742

Draft
connortsui20 wants to merge 1 commit into
developfrom
ct/row-fn-cleanup/canonical-validity
Draft

connortsui20 wants to merge 1 commit into
developfrom
ct/row-fn-cleanup/canonical-validity

Attach batch validity directly to canonical RowFn output

c0f37b3
Select commit
Loading
Failed to load commit list.
CodSpeed / CodSpeed Performance Analysis failed Oct 23, 2026 in 0s

Performance Regression: -4.67%

4 warnings, 1 note

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ Unable to measure the execution of 2 benchmarks

These benchmarks measured no execution time, so their results are not comparable and count as unchanged. This usually happens when the compiler removes the code under test.

Prevent compiler optimizations

See affected benchmarks

⚠️ 16 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ Base and head ran on different runner types

Some benchmarks with significant performance changes were compared across different runner types, so the changes might not come from the code. Run base and head on the same runner type, or use CodSpeed Macro Runners for more stable results.

Learn more about Macro Runners

Open the report in CodSpeed to investigate

ℹ️ 40 benchmarks have no flamegraph

The flamegraph wasn't generated: the symbols of the profiling trace could not be resolved, because no information about the language frames was collected.

See affected benchmarks

⚡ 6 improved benchmarks
❌ 6 regressed benchmarks
✅ 2396 untouched benchmarks
⏩ 12 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Walltime mul_u64_nonnull_neon 20.5 µs 40.4 µs -49.2%
❌ CPU Simulation filter_powerlaw_by_mostly_false[250000] 138.7 µs 158.7 µs -12.62%
❌ CPU Simulation filter_random_by_mostly_false[250000] 163.2 µs 183.7 µs -11.19%
❌ CPU Simulation filter_powerlaw_by_power_law[250000] 166.2 µs 185.7 µs -10.54%
❌ CPU Simulation filter_random_by_power_law[250000] 166.1 µs 185.5 µs -10.48%
❌ CPU Simulation density_sweep_dense_runs[0.001] 53.6 µs 59.7 µs -10.32%
⚡ CPU Simulation test_scan_filter_to_arrow_array[int_float] 4.1 ms 3.5 ms +15.84%
⚡ CPU Simulation test_repeated_scan_filter[int_float] 3.9 ms 3.4 ms +12.15%
⚡ Walltime starts_with_avx2[64, VarBin] 62.7 µs 56 µs +11.84%
⚡ CPU Simulation test_repeated_scan_filter[int] 2.7 ms 2.4 ms +11.38%
⚡ CPU Simulation test_scan_filter_to_arrow_array[int] 2.8 ms 2.5 ms +11.05%
⚡ Walltime add_constant_shapes_neon[(32768, PerRowConstant)] 15.9 µs 14.3 µs +10.78%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ct/row-fn-cleanup/canonical-validity (c0f37b3) with develop (d02df89)

Open in CodSpeed

Footnotes

  1. 12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩