Repository navigation
Fix semantic conflict in vortex-file tests - #10731
Conversation
…roundtrip Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Merging this PR will degrade performance by 1.74%3 warnings, 1 note
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
Summary
Develop doesn't compile vortex-file's tests. #10533 added
nested_empty_list_roundtrip, which callsListArray::try_newwith three arguments, but #10594 had already added a fourth, the execution context. Both passed CI on their own. Since #10533 merged, the Rust build, lint and test jobs fail on develop and on every PR.Changes
nested_empty_list_roundtripcreates an execution context and passes it to bothListArray::try_newcalls, asnested_list_of_list_roundtripjust above it already does.Testing
cargo nextest run -p vortex-file -E 'test(/nested_empty_list_roundtrip|nested_list_of_list_roundtrip/)'(5 passed)cargo clippy -p vortex-file --all-targets --all-features -- -D warningscargo +nightly-2026-09-10 fmt -p vortex-file --check