Skip to content

feat(cuda): add minimal CUDA driver bindings - #10719

Merged
0ax1 merged 1 commit into
developfrom
ad/cuda-driver-bindings
Oct 23, 2026
Merged

0ax1 merged 1 commit into
developfrom
ad/cuda-driver-bindings

Conversation

@0ax1

@0ax1 0ax1 commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Problem

The driver replacement needs a small CUDA binding layer with lazy library loading.

Solution

Add raw handles, symbols, errors, and fallible call wrappers in vortex-cuda-driver.

Assessment

The crate is excluded from publishing; existing consumers still use cudarc. Based on #10726 and prerequisite for #10720.

@codspeed

codspeed Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 13.14%

2 warnings, 1 note

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ 15 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

ℹ️ 40 benchmarks have no flamegraph

The flamegraph wasn't generated: the symbols of the profiling trace could not be resolved, because no information about the language frames was collected.

See affected benchmarks

⚡ 3 improved benchmarks
❌ 8 regressed benchmarks
✅ 2397 untouched benchmarks
⏩ 12 skipped benchmarks1
🗄️ 43 archived benchmarks run2

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Walltime threshold_neon[8] 1.3 µs 2.8 µs -52.13%
❌ Walltime filter_neon[8] 936 ns 1,424 ns -34.27%
❌ Walltime threshold_neon[64] 2.6 µs 3.9 µs -33.32%
❌ Walltime threshold_neon[80] 3.6 µs 4.4 µs -19.07%
❌ Walltime filter_neon[80] 2.5 µs 2.9 µs -14.85%
❌ Walltime filter_neon[64] 1.8 µs 2.1 µs -13.49%
❌ Walltime starts_with_avx512[8, VarBin] 40 µs 45.7 µs -12.49%
❌ Walltime bitpack_blocked_compress_avx2 6.8 µs 7.6 µs -10.57%
⚡ CPU Simulation decode_primitives[i64, (1000, 8)] 37.6 µs 24 µs +56.62%
⚡ CPU Simulation take[routing/alternating_chunks/primitive/nonnull/chunks=32/indices=1000] 247.1 µs 196.7 µs +25.61%
⚡ Walltime words_gather_dispatch_neon[65536] 2 µs 1.8 µs +10.18%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ad/cuda-driver-bindings (3c6c195) with develop (e083440)

Open in CodSpeed

Footnotes

  1. 12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. 43 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them. ↩

@0ax1 0ax1 added the changelog/feature A new feature label Oct 23, 2026 — with ChatGPT Codex Connector
@0ax1
0ax1 changed the base branch from develop to ad/ctutils-security-update October 23, 2026 13:13
@0ax1
0ax1 force-pushed the ad/cuda-driver-bindings branch from 60b9ab5 to 172564e Compare October 23, 2026 13:13
@0ax1
0ax1 requested a review from robert3005 October 23, 2026 14:50
@0ax1
0ax1 marked this pull request as ready for review October 23, 2026 14:51
Base automatically changed from ad/ctutils-security-update to develop October 23, 2026 15:34
Introduce vortex-cuda-driver with lazily loaded CUDA symbols, raw handle types, and fallible driver-call wrappers. Register the crate in the workspace while leaving existing cudarc consumers unchanged.

Original-commit: 5fd3f54eba
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1
0ax1 force-pushed the ad/cuda-driver-bindings branch from 172564e to 3c6c195 Compare October 23, 2026 15:46
@0ax1
0ax1 merged commit 1de85c8 into develop Oct 23, 2026
89 of 90 checks passed
@0ax1
0ax1 deleted the ad/cuda-driver-bindings branch October 23, 2026 15:59
0ax1 added a commit that referenced this pull request Oct 23, 2026
## Problem

Raw CUDA handles do not manage ownership, thread-context binding, or cleanup errors.

## Solution

Add owned and borrowed contexts, streams, events, and modules with explicit binding and deferred error handling.

## Assessment

Depends on #10719. The crate remains unpublished; consumers switch in #10722.

Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants