Repository navigation
Conversation
Merging this PR will degrade performance by 12.09%2 warnings, 1 note
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
8ba0f78 to
d91362d
Compare
8ed5762 to
18c5897
Compare
robert3005
left a comment
There was a problem hiding this comment.
I wonder if there's a thing that already runs on a per thread basis that we can move this to instead of having a thread
On devices that read pageable memory through host page tables, copy resident mapped-file ranges directly into device memory. Preserve staged reads for uncached ranges and direct I/O, source and destination alignment, cancellation safety, and mapping lifetime guards. Use the existing file-read chunk size so this feature is independent of chunk-size tuning. Original-commit: b546d93814 Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Cache mappings by file identity and version so repeated scans reuse filled page tables. Add Rust and C APIs to release cached mappings before cold-cache eviction while active readers retain their mappings. Include reuse, versioning, release, and concurrent-read coverage. Original-commit: a31e77427e Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
18c5897 to
a149621
Compare
Move closed readers' copy-stream waits and mapping release onto a background worker. Drain queued releases before explicit cache eviction and retain mappings when synchronization fails. Include the release-before-return regression test. Original-commit: e1b178661a Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
d91362d to
8845ef7
Compare
a149621 to
34a45d9
Compare
Problem
Closing a mapped reader can stall decoding while waiting for GPU copies and releasing page tables.
Solution
Move synchronization and mapping release to a background worker; drain queued releases before explicit cache eviction.
Assessment
Falls back to synchronous release if queuing fails and retains mappings if completion is unknown. Depends on #10717.