Skip to content

perf(cuda): read pooled files in 8 MiB chunks - #10715

Merged
0ax1 merged 1 commit into
developfrom
ad/cuda-file-read-chunks
Oct 23, 2026
Merged

0ax1 merged 1 commit into
developfrom
ad/cuda-file-read-chunks

Conversation

@0ax1

@0ax1 0ax1 commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Splitting staged file reads into 4 MiB chunks adds per-chunk I/O and transfer overhead.

Solution

Increase physical read and H2D chunks to 8 MiB, retaining concurrency 32 and existing logical batches.

Assessment

Uses larger staging buffers per request. Independent of mapped-file copying; based on #10726.

@codspeed

codspeed Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Merging this PR will regress 3 benchmarks

2 warnings, 1 note

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ 14 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

ℹ️ 40 benchmarks have no flamegraph

The flamegraph wasn't generated: the symbols of the profiling trace could not be resolved, because no information about the language frames was collected.

See affected benchmarks

⚡ 3 improved benchmarks
❌ 3 regressed benchmarks
✅ 2402 untouched benchmarks
⏩ 12 skipped benchmarks1
🗄️ 43 archived benchmarks run2

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Walltime threshold_neon[80] 3.6 µs 4.3 µs -16.02%
❌ Walltime starts_with_avx512[8, VarBin] 40 µs 44.7 µs -10.57%
❌ Walltime bitpack_blocked_compress_avx2 6.8 µs 7.6 µs -10.38%
⚡ CPU Simulation decode_primitives[i64, (1000, 8)] 37.6 µs 24 µs +56.62%
⚡ CPU Simulation take[routing/alternating_chunks/primitive/nonnull/chunks=32/indices=1000] 247.1 µs 196.7 µs +25.59%
⚡ Walltime words_gather_dispatch_neon[65536] 2 µs 1.8 µs +10.12%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ad/cuda-file-read-chunks (a5374f5) with develop (e083440)

Open in CodSpeed

Footnotes

  1. 12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. 43 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them. ↩

@0ax1 0ax1 added the changelog/performance A performance improvement label Oct 23, 2026 — with ChatGPT Codex Connector
@0ax1
0ax1 changed the base branch from develop to ad/ctutils-security-update October 23, 2026 13:13
@0ax1
0ax1 force-pushed the ad/cuda-file-read-chunks branch from ad17bf0 to 33595aa Compare October 23, 2026 13:13
@0ax1
0ax1 requested a review from robert3005 October 23, 2026 14:50
@0ax1
0ax1 marked this pull request as ready for review October 23, 2026 14:51
Base automatically changed from ad/ctutils-security-update to develop October 23, 2026 15:34
Increase physical staged-read and H2D chunks from 4 MiB to 8 MiB while preserving concurrency and logical scan batches. Keep the read-size documentation and boundary-test comment with the change.

Original-commit: ccd8ae8f00
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1
0ax1 force-pushed the ad/cuda-file-read-chunks branch from 33595aa to a5374f5 Compare October 23, 2026 15:45
@0ax1
0ax1 merged commit 8c680f2 into develop Oct 23, 2026
110 of 116 checks passed
@0ax1
0ax1 deleted the ad/cuda-file-read-chunks branch October 23, 2026 17:02
0ax1 added a commit that referenced this pull request Oct 23, 2026
## Problem

Cached file pages still pass through pinned staging buffers before reaching the GPU.

## Solution

On supported Linux devices, copy resident mapped-file ranges directly with a CUDA kernel; retain staged reads for other cases.

## Assessment

Hardware-dependent fast path with mapping lifetime and cancellation guards. Keeps 4 MiB chunks, so it is independent of #10715. Based on #10726.

Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/performance A performance improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants