Skip to content

fix(cuda): retain pinned sources across transfer failures - #10712

Merged
0ax1 merged 1 commit into
developfrom
ad/cuda-pinned-transfer-safety
Oct 23, 2026
Merged

0ax1 merged 1 commit into
developfrom
ad/cuda-pinned-transfer-safety

Conversation

@0ax1

@0ax1 0ax1 commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Problem

A failed or resubmitted transfer can recycle pinned source memory before its previous DMA completes.

Solution

Check contexts, wait on the previous source fence, and establish completion before recycling buffers.

Assessment

If completion cannot be established, retain the allocation rather than risk freeing active DMA memory. Based on #10726; prerequisite for #10713.

@codspeed

codspeed Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 14.95%

2 warnings, 1 note

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ 16 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

ℹ️ 40 benchmarks have no flamegraph

The flamegraph wasn't generated: the symbols of the profiling trace could not be resolved, because no information about the language frames was collected.

See affected benchmarks

⚡ 2 improved benchmarks
❌ 8 regressed benchmarks
✅ 2398 untouched benchmarks
⏩ 12 skipped benchmarks1
🗄️ 43 archived benchmarks run2

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Walltime threshold_neon[8] 1.3 µs 2.6 µs -48.42%
❌ Walltime threshold_neon[64] 2.6 µs 4 µs -34.94%
❌ Walltime filter_neon[8] 936 ns 1,359 ns -31.13%
❌ Walltime threshold_neon[80] 3.6 µs 4.5 µs -20.04%
❌ CPU Simulation test_repeated_scan_scalar_at[int_str_float] 494.6 µs 588 µs -15.88%
❌ Walltime filter_neon[80] 2.5 µs 3 µs -15.28%
❌ Walltime filter_neon[64] 1.8 µs 2.1 µs -14.74%
❌ Walltime bitpack_blocked_compress_avx2 6.8 µs 7.6 µs -10.29%
⚡ CPU Simulation decode_primitives[i64, (1000, 8)] 37.6 µs 24 µs +56.62%
⚡ CPU Simulation take[routing/alternating_chunks/primitive/nonnull/chunks=32/indices=1000] 247.1 µs 196.7 µs +25.6%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ad/cuda-pinned-transfer-safety (cd9ea47) with develop (e083440)

Open in CodSpeed

Footnotes

  1. 12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. 43 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them. ↩

@0ax1 0ax1 added the changelog/fix A bug fix label Oct 23, 2026 — with ChatGPT Codex Connector
@0ax1
0ax1 changed the base branch from develop to ad/ctutils-security-update October 23, 2026 13:13
@0ax1
0ax1 force-pushed the ad/cuda-pinned-transfer-safety branch from 1f87c45 to 40f13e2 Compare October 23, 2026 13:13
@0ax1
0ax1 requested a review from robert3005 October 23, 2026 14:50
@0ax1
0ax1 marked this pull request as ready for review October 23, 2026 14:51
Base automatically changed from ad/ctutils-security-update to develop October 23, 2026 15:34
Validate the transfer context and wait for the previous source fence before replacing it. On submission or fence failure, synchronize the stream before recycling the source, retaining the allocation if completion cannot be established. Include ownership regression tests and bind the context explicitly before pinned allocation.

Original-commit: 94897853df
Original-commit: a2f6ce3b37
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1
0ax1 force-pushed the ad/cuda-pinned-transfer-safety branch from 40f13e2 to cd9ea47 Compare October 23, 2026 15:44
@0ax1
0ax1 merged commit c750fbd into develop Oct 23, 2026
161 of 168 checks passed
@0ax1
0ax1 deleted the ad/cuda-pinned-transfer-safety branch October 23, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants